From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: fw@strlen.de, sbrivio@redhat.com
Subject: Re: [PATCH nf,v2 1/2] netfilter: nft_set_rbtree: Switch to node list walk for overlap detection
Date: Tue, 17 Jan 2023 16:19:46 +0100 [thread overview]
Message-ID: <Y8a8kkCJZlG58kWB@salvia> (raw)
In-Reply-To: <20230117112800.52379-1-pablo@netfilter.org>
On Tue, Jan 17, 2023 at 12:27:59PM +0100, Pablo Neira Ayuso wrote:
[...]
> Otherwise, with large sets, starting from rb_first() is slow (it takes
> 30s if I use rb_first() instead of this approach), because of the linear
> list walk.
This should be instead:
Otherwise, with large sets, starting from rb_first() is slow (it takes
30s if I use rb_first() instead of 3s), because of the linear list
walk.
so it is 3 seconds with the speed up vs. 30 seconds starting from rb_first().
prev parent reply other threads:[~2023-01-17 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 11:27 [PATCH nf,v2 1/2] netfilter: nft_set_rbtree: Switch to node list walk for overlap detection Pablo Neira Ayuso
2023-01-17 11:28 ` [PATCH nf,v2 2/2] netfilter: nft_set_rbtree: skip elements in transaction from garbage collection Pablo Neira Ayuso
2023-01-17 15:19 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8a8kkCJZlG58kWB@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.