From: Guillaume Nault <gnault@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot+bbd35b345c7cab0d9a08@syzkaller.appspotmail.com,
Cong Wang <cong.wang@bytedance.com>
Subject: Re: [PATCH net] l2tp: prevent lockdep issue in l2tp_tunnel_register()
Date: Tue, 17 Jan 2023 12:20:57 +0100 [thread overview]
Message-ID: <Y8aEmeorHCmRNccR@debian> (raw)
In-Reply-To: <20230117110131.1362738-1-edumazet@google.com>
On Tue, Jan 17, 2023 at 11:01:31AM +0000, Eric Dumazet wrote:
> lockdep complains with the following lock/unlock sequence:
>
> lock_sock(sk);
> write_lock_bh(&sk->sk_callback_lock);
> [1] release_sock(sk);
> [2] write_unlock_bh(&sk->sk_callback_lock);
>
> We need to swap [1] and [2] to fix this issue.
Reviewed-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2023-01-17 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 11:01 [PATCH net] l2tp: prevent lockdep issue in l2tp_tunnel_register() Eric Dumazet
2023-01-17 11:20 ` Guillaume Nault [this message]
2023-01-18 14:50 ` patchwork-bot+netdevbpf
2023-01-18 17:10 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8aEmeorHCmRNccR@debian \
--to=gnault@redhat.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+bbd35b345c7cab0d9a08@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.