From: Jason Gunthorpe <jgg@nvidia.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"Tian, Kevin" <kevin.tian@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v2] vfio: Support VFIO_NOIOMMU with iommufd
Date: Tue, 17 Jan 2023 09:33:50 -0400 [thread overview]
Message-ID: <Y8ajvgYMgM+dKUWJ@nvidia.com> (raw)
In-Reply-To: <DS0PR11MB75292238656F19908C0D0A4BC3C69@DS0PR11MB7529.namprd11.prod.outlook.com>
On Tue, Jan 17, 2023 at 05:14:12AM +0000, Liu, Yi L wrote:
> Hi Jason,
>
> > diff --git a/drivers/vfio/iommufd.c b/drivers/vfio/iommufd.c
> > index 4f82a6fa7c6c7f..79a781a4e74c09 100644
> > --- a/drivers/vfio/iommufd.c
> > +++ b/drivers/vfio/iommufd.c
> > @@ -18,6 +18,21 @@ int vfio_iommufd_bind(struct vfio_device *vdev,
> > struct iommufd_ctx *ictx)
> >
> > lockdep_assert_held(&vdev->dev_set->lock);
> >
> > + if (IS_ENABLED(CONFIG_VFIO_NOIOMMU) &&
> > + vdev->group->type == VFIO_NO_IOMMU) {
>
> This should be done with a helper provided by group.c as it tries
> to decode the group fields. Is it?
It will make your cdev series easier
Jason
next prev parent reply other threads:[~2023-01-17 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 20:07 [PATCH v2] vfio: Support VFIO_NOIOMMU with iommufd Jason Gunthorpe
2023-01-11 5:01 ` Tian, Kevin
2023-01-17 5:14 ` Liu, Yi L
2023-01-17 13:33 ` Jason Gunthorpe [this message]
2023-01-17 13:51 ` Liu, Yi L
2023-01-17 22:02 ` Alex Williamson
2023-01-18 15:47 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8ajvgYMgM+dKUWJ@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.