From: Andrew Lunn <andrew@lunn.ch>
To: Pierluigi Passaro <pierluigi.p@variscite.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
eran.m@variscite.com, nate.d@variscite.com,
francesco.f@variscite.com, pierluigi.passaro@gmail.com
Subject: Re: [PATCH net-next v3] net: mdio: force deassert MDIO reset signal
Date: Tue, 17 Jan 2023 14:46:42 +0100 [thread overview]
Message-ID: <Y8amwmZLajZfum89@lunn.ch> (raw)
In-Reply-To: <20230116160114.36467-1-pierluigi.p@variscite.com>
On Mon, Jan 16, 2023 at 05:01:14PM +0100, Pierluigi Passaro wrote:
> When the reset gpio is defined within the node of the device tree
> describing the PHY, the reset is initialized and managed only after
> calling the fwnode_mdiobus_phy_device_register function.
> However, before calling it, the MDIO communication is checked by the
> get_phy_device function.
> When this happens and the reset GPIO was somehow previously set down,
> the get_phy_device function fails, preventing the PHY detection.
> These changes force the deassert of the MDIO reset signal before
> checking the MDIO channel.
> The PHY may require a minimum deassert time before being responsive:
> use a reasonable sleep time after forcing the deassert of the MDIO
> reset signal.
> Once done, free the gpio descriptor to allow managing it later.
>
> Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
> Signed-off-by: FrancescoFerraro <francesco.f@variscite.com>
FYI: There is still a discussion going on in v1 of this patch. Please
do not merge yet.
Andrew
prev parent reply other threads:[~2023-01-17 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 16:01 [PATCH net-next v3] net: mdio: force deassert MDIO reset signal Pierluigi Passaro
2023-01-17 13:46 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8amwmZLajZfum89@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eran.m@variscite.com \
--cc=francesco.f@variscite.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nate.d@variscite.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pierluigi.p@variscite.com \
--cc=pierluigi.passaro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.