From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81BCEC3DA78 for ; Tue, 17 Jan 2023 14:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbjAQOKZ (ORCPT ); Tue, 17 Jan 2023 09:10:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231468AbjAQOKY (ORCPT ); Tue, 17 Jan 2023 09:10:24 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFF7A2A163; Tue, 17 Jan 2023 06:10:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 99F6BB81645; Tue, 17 Jan 2023 14:10:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB1F9C433D2; Tue, 17 Jan 2023 14:10:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673964621; bh=1LQNFj0nyxhQ3JRrf8nhxOpkNbiHaRBCqv2yNnBl7JI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h74ssUzgixd7/MX7aln510ZzUSGlvxrMC2fWe1KPCNxqb1Uofh5aIOyn6gf8yI9Mx 7ytiUBK7gdiVe/1CCl80lRBPCLYW+xIHRt/VH4DhLVN8G4nQ1YwT38xZ7gGr9tFZIo EzcZPmIfUCqzXZJpQnfjrUca1r7Z7c5ioCtFayaM= Date: Tue, 17 Jan 2023 15:10:18 +0100 From: Greg KH To: Nipun Gupta Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, rafael@kernel.org, eric.auger@redhat.com, alex.williamson@redhat.com, cohuck@redhat.com, song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org, maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com, saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org, yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com, robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, masahiroy@kernel.org, ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, okaya@kernel.org, harpreet.anand@amd.com, nikhil.agarwal@amd.com, michal.simek@amd.com, git@amd.com Subject: Re: [PATCH 05/19] bus/cdx: add cdx controller Message-ID: References: <20230117134139.1298-1-nipun.gupta@amd.com> <20230117134139.1298-6-nipun.gupta@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230117134139.1298-6-nipun.gupta@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Tue, Jan 17, 2023 at 07:11:37PM +0530, Nipun Gupta wrote: > --- /dev/null > +++ b/drivers/bus/cdx/controller/cdx_controller.c > @@ -0,0 +1,243 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Platform driver for CDX bus controller. Why is this a platform driver? Shouldn't it also be on some type of bus so that you can find it? > +MODULE_VERSION("1.0"); There's never need for any module versions once the code is in the kernel tree as then they make no sense at all. Please drop them from this series. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B1D4C3DA78 for ; Tue, 17 Jan 2023 14:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q6t7kqZTE8qJAvCWGClB+wWqtgC5b3RNlg4rmaRQhu0=; b=N/TjigcGQoi1Mv 30gxDgm7sHS0yzhgJ+g9Ja1VjH29uDZxivDaR7ikzblEdzMiZQ1sLDHZl6w1hOuyyOwI+0JNIZndL gLe/mm88yPzkHYjR5G+/8jL6z8qMffSM+MNF7tKU+fm4L9gTZzwFp46XmB9qKJVIZ1csUlnwFjb/R MjadyVX/v+keK1Qh3fB3Uz3f/Ut8/8Bj1dwe5ib/yO5TLiwHUEnVVIk2cRajCY/HacMSL35gZVAKt FUosk03zBaLG/z17bx2vcPRexNolcKhTwgR4cXE1Te/6mOaBtw/hMM5o8TwzR1YnkVq8DLDr37yJx NbbhKAe5AB7TEpX8i2GQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHmfS-00EYfA-D0; Tue, 17 Jan 2023 14:10:26 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHmfO-00EYdr-R4 for linux-arm-kernel@lists.infradead.org; Tue, 17 Jan 2023 14:10:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D009561456; Tue, 17 Jan 2023 14:10:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB1F9C433D2; Tue, 17 Jan 2023 14:10:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673964621; bh=1LQNFj0nyxhQ3JRrf8nhxOpkNbiHaRBCqv2yNnBl7JI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h74ssUzgixd7/MX7aln510ZzUSGlvxrMC2fWe1KPCNxqb1Uofh5aIOyn6gf8yI9Mx 7ytiUBK7gdiVe/1CCl80lRBPCLYW+xIHRt/VH4DhLVN8G4nQ1YwT38xZ7gGr9tFZIo EzcZPmIfUCqzXZJpQnfjrUca1r7Z7c5ioCtFayaM= Date: Tue, 17 Jan 2023 15:10:18 +0100 From: Greg KH To: Nipun Gupta Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, rafael@kernel.org, eric.auger@redhat.com, alex.williamson@redhat.com, cohuck@redhat.com, song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org, maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com, saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org, yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com, robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, masahiroy@kernel.org, ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, okaya@kernel.org, harpreet.anand@amd.com, nikhil.agarwal@amd.com, michal.simek@amd.com, git@amd.com Subject: Re: [PATCH 05/19] bus/cdx: add cdx controller Message-ID: References: <20230117134139.1298-1-nipun.gupta@amd.com> <20230117134139.1298-6-nipun.gupta@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230117134139.1298-6-nipun.gupta@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230117_061022_930668_9992153E X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 17, 2023 at 07:11:37PM +0530, Nipun Gupta wrote: > --- /dev/null > +++ b/drivers/bus/cdx/controller/cdx_controller.c > @@ -0,0 +1,243 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Platform driver for CDX bus controller. Why is this a platform driver? Shouldn't it also be on some type of bus so that you can find it? > +MODULE_VERSION("1.0"); There's never need for any module versions once the code is in the kernel tree as then they make no sense at all. Please drop them from this series. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel