From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB8F7C6379F for ; Tue, 17 Jan 2023 16:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230080AbjAQQD0 (ORCPT ); Tue, 17 Jan 2023 11:03:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbjAQQDW (ORCPT ); Tue, 17 Jan 2023 11:03:22 -0500 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9649D3029C for ; Tue, 17 Jan 2023 08:03:20 -0800 (PST) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1pHoQg-0003Ou-5f; Tue, 17 Jan 2023 17:03:18 +0100 Date: Tue, 17 Jan 2023 17:03:18 +0100 From: Phil Sutter To: Pablo Neira Ayuso Cc: Jan Engelhardt , netfilter-devel@vger.kernel.org, Arturo Borrero Gonzalez Subject: Re: [PATCH] build: put xtables.conf in EXTRA_DIST Message-ID: Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , Jan Engelhardt , netfilter-devel@vger.kernel.org, Arturo Borrero Gonzalez References: <20230112225517.31560-1-jengelh@inai.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Jan 17, 2023 at 04:56:35PM +0100, Pablo Neira Ayuso wrote: > On Tue, Jan 17, 2023 at 04:50:27PM +0100, Phil Sutter wrote: > > On Mon, Jan 16, 2023 at 06:18:34PM +0100, Jan Engelhardt wrote: > > > > > > On Monday 2023-01-16 12:57, Pablo Neira Ayuso wrote: > > > >On Fri, Jan 13, 2023 at 12:47:30PM +0100, Phil Sutter wrote: > > > > > > > >IIRC ebtables is using a custom ethertype file, because definitions > > > >are different there. > > > > > > > >But is this installed file used in any way these days? > > > > > > Probably not; the version I have has this to say: > > > > > > # This list could be found on: > > > # http://www.iana.org/assignments/ethernet-numbers > > > # http://www.iana.org/assignments/ieee-802-numbers > > > > > > With such official-ness, ebtables's ethertypes has a rather low priority. > > > > This header statement exists even in legacy ebtables repo' version. I > > fear the opposite is the case and everyone's rather copying from ebtables > > or iptables just to provide /etc/ethertypes without depending on the > > tools. > > > > My local Gentoo install at least has /etc/ethertypes exactly as in > > ebtables repo and the package source states "File extracted from the > > iptables tarball". > > > > Maybe we're the original source? > > In ebtables, there _PATH_ETHERTYPES which is indirectly used by > getethertypebyname() by a few extensions. > > In iptables, this code exists too, using a different definition: > > include/xtables.h:#define XT_PATH_ETHERTYPES "/etc/ethertypes" > > extensions/libebt_arp.c: ent = xtables_getethertypebyname(argv[optind - 1]); > extensions/libebt_vlan.c: ethent = xtables_getethertypebyname(optarg); > > It seems this file is required by a few extensions and the translation > infrastructure. Thanks for investigating. I guess dropping a file we depend on to exist *and* introduced in the first place is shooting one's own foot with extra steps. Also packagers are used to ignore the file (if not needed) already. :) Cheers, Phil