From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 0/4] drm/i915: GMCH refactoring
Date: Tue, 17 Jan 2023 11:14:05 -0500 [thread overview]
Message-ID: <Y8bJTQ4mVUGSvct3@intel.com> (raw)
In-Reply-To: <cover.1673958757.git.jani.nikula@intel.com>
On Tue, Jan 17, 2023 at 02:33:05PM +0200, Jani Nikula wrote:
> Let's see if this sticks.
Suddenly all of these 'bridge_dev' makes some sense to me.
I believe we could enjoy the refactor here and add some documentation
about this... at least the name Graphics Memory Controller Hub name...
I also wonder if we should make this a child device now that it is
really organized...
But anyway, everything can be a follow up, the current refactor
is already a very good clean up step, so for the series:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Jani Nikula (4):
> drm/i915: add gmch substruct to struct drm_i915_private
> drm/i915/gmch: split out soc/intel_gmch
> drm/i915/gmch: mass rename dev_priv to i915
> drm/i915/gmch: move VGA set state to GMCH code
>
> drivers/gpu/drm/i915/Makefile | 1 +
> drivers/gpu/drm/i915/display/intel_vga.c | 32 +---
> drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c | 2 +-
> drivers/gpu/drm/i915/i915_driver.c | 145 +-----------------
> drivers/gpu/drm/i915/i915_drv.h | 10 +-
> drivers/gpu/drm/i915/soc/intel_gmch.c | 171 ++++++++++++++++++++++
> drivers/gpu/drm/i915/soc/intel_gmch.h | 18 +++
> 7 files changed, 204 insertions(+), 175 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.c
> create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.h
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-01-17 16:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 12:33 [Intel-gfx] [PATCH 0/4] drm/i915: GMCH refactoring Jani Nikula
2023-01-17 12:33 ` [Intel-gfx] [PATCH 1/4] drm/i915: add gmch substruct to struct drm_i915_private Jani Nikula
2023-01-17 12:33 ` [Intel-gfx] [PATCH 2/4] drm/i915/gmch: split out soc/intel_gmch Jani Nikula
2023-01-17 12:33 ` [Intel-gfx] [PATCH 3/4] drm/i915/gmch: mass rename dev_priv to i915 Jani Nikula
2023-01-17 12:33 ` [Intel-gfx] [PATCH 4/4] drm/i915/gmch: move VGA set state to GMCH code Jani Nikula
2023-01-17 13:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: GMCH refactoring Patchwork
2023-01-17 14:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-01-17 16:14 ` Rodrigo Vivi [this message]
2023-01-25 11:57 ` [Intel-gfx] [PATCH 0/4] " Jani Nikula
2023-01-17 16:23 ` Ville Syrjälä
2023-01-18 8:45 ` Jani Nikula
2023-01-17 17:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: GMCH refactoring (rev2) Patchwork
2023-01-17 17:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-01-18 5:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8bJTQ4mVUGSvct3@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.