From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A4DC54E76 for ; Tue, 17 Jan 2023 19:10:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229645AbjAQTJw (ORCPT ); Tue, 17 Jan 2023 14:09:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234293AbjAQTGP (ORCPT ); Tue, 17 Jan 2023 14:06:15 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E88031E11 for ; Tue, 17 Jan 2023 10:21:08 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3AF5B1EC0646; Tue, 17 Jan 2023 19:21:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1673979667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=+T1m25y4fv/I7wmutJr3X2Xf96TTvoaLQHG3Ee2Hbd8=; b=eQTHj+t56cfBRckrQuH0F+smzlVLvLx1PSA70Iqjnl9qUXjl+byKI4sFB/RoUijbrucROf FsSwsOhuWYXSf7xArt3Iv0Gn3apk1RyLxP4pZMolzMjbTLFNlPkWNoR6GyKeLAn/+ecaco micpkV05juwzgVOy919+dJzmst1Aego= Date: Tue, 17 Jan 2023 19:21:06 +0100 From: Borislav Petkov To: Dave Hansen Cc: Ashok Raj , Thomas Gleixner , X86-kernel , LKML Mailing List , Tony Luck , Ingo Molnar , alison.schofield@intel.com, reinette.chatre@intel.com, Tom Lendacky Subject: Re: [PATCH v4 6/6] x86/microcode/intel: Print when early microcode loading fails Message-ID: References: <20230109153555.4986-1-ashok.raj@intel.com> <20230109153555.4986-7-ashok.raj@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2023 at 08:29:28AM -0800, Dave Hansen wrote: > This ensures that a message of some kind is printed on all early loads: > successes *and* failures. This should make it easier for our hapless > users to figure out when a failure occurred. I'm still not convinced. When something doesn't happen in the kernel, we don't always say "It didn't happen". We don't say anything. So I don't like all those talkative drivers for no good reason. If there wasn't an update message, then no update happened. That's it. And the current microcode revision is in /proc/cpuinfo. If you wanna know why the update didn't happen, then you start adding debug printks and trying things but then you're clearly not a user so you know what you're doing. And the log buffer can get overwritten sooner or later depending on its size so any message can disappear. So what's the point of this pointless exercise in verbosity? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette