From: Dan Carpenter <error27@gmail.com>
To: Antoine Tenart <atenart@kernel.org>
Cc: linux-clk@vger.kernel.org
Subject: Re: [bug report] net: macb: convert to phylink
Date: Wed, 18 Jan 2023 11:36:45 +0300 [thread overview]
Message-ID: <Y8evnRh4y6GVMnyZ@kadam> (raw)
In-Reply-To: <167396948997.3401.13412978788541812942@kwain.local>
On Tue, Jan 17, 2023 at 04:31:29PM +0100, Antoine Tenart wrote:
> Quoting Dan Carpenter (2023-01-17 14:58:12)
> >
> > The patch 7897b071ac3b: "net: macb: convert to phylink" from Nov 13,
> > 2019, leads to the following Smatch static checker warning:
>
> I don't think the above commit is the right one, macb_set_tx_clk wasn't
> called while holding a spinlock at the time. This behaviour seemed to
> have been introduced by commit 633e98a711ac ("net: macb: use resolved
> link config in mac_link_up()").
>
Oh, yeah. You're right. Let me send this to Russell.
regards,
dan carpenter
prev parent reply other threads:[~2023-01-18 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 13:58 [bug report] net: macb: convert to phylink Dan Carpenter
2023-01-17 15:31 ` Antoine Tenart
2023-01-18 8:36 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8evnRh4y6GVMnyZ@kadam \
--to=error27@gmail.com \
--cc=atenart@kernel.org \
--cc=linux-clk@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.