From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>
Subject: Re: [PATCH] tests/qtest/qom-test: Stop spamming the test log
Date: Wed, 18 Jan 2023 12:31:38 +0000 [thread overview]
Message-ID: <Y8fmqiOzJaVbufbY@redhat.com> (raw)
In-Reply-To: <20230118122557.1668860-1-thuth@redhat.com>
On Wed, Jan 18, 2023 at 01:25:57PM +0100, Thomas Huth wrote:
> We are still facing the issues that our test logs in the gitlab CI
> are too big (and thus cut off). A huge part is still caused by the
> qom-test that prints the path and name of each object it looks at
> by default. That's too much. Let's be silent by default, and only
> print the object path+name when running with V=2 (and the properties
> only with V=3 and higher).
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qtest/qom-test.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-01-18 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 12:25 [PATCH] tests/qtest/qom-test: Stop spamming the test log Thomas Huth
2023-01-18 12:31 ` Daniel P. Berrangé [this message]
2023-01-18 14:42 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8fmqiOzJaVbufbY@redhat.com \
--to=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.