From: Sean Christopherson <seanjc@google.com>
To: Colton Lewis <coltonlewis@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, maz@kernel.org,
dmatlack@google.com, bgardon@google.com, oupton@google.com,
ricarkol@google.com
Subject: Re: [PATCH 1/3] KVM: selftests: Allocate additional space for latency samples
Date: Wed, 18 Jan 2023 16:49:31 +0000 [thread overview]
Message-ID: <Y8gjG6gG5UR6T3Yg@google.com> (raw)
In-Reply-To: <20221115173258.2530923-2-coltonlewis@google.com>
On Tue, Nov 15, 2022, Colton Lewis wrote:
> Allocate additional space for latency samples. This has been separated
> out to call attention to the additional VM memory allocation.
A blurb in the changelog is sufficient, no need to split allocation and use into two
patches. I would actually collapse all three into one. The changes aren't so big
that errors will be difficult to bisect, and without the final printing, the other
changes are useless for all intents and purposes, i.e. if for some reason we want
to revert the sampling, it will be all or nothing.
I do think it makes sense to separate the system counter stuff to a separate
patch (and land it in generic code), e.g. add helpers to read the system counter
from the guest and convert the result to nanoseconds in a separate patch.
next prev parent reply other threads:[~2023-01-18 16:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 17:32 [PATCH 0/3] Calculate memory access latency stats Colton Lewis
2022-11-15 17:32 ` [PATCH 1/3] KVM: selftests: Allocate additional space for latency samples Colton Lewis
2023-01-17 20:32 ` Ricardo Koller
2023-01-18 16:49 ` Sean Christopherson [this message]
2023-01-26 18:00 ` Colton Lewis
2022-11-15 17:32 ` [PATCH 2/3] KVM: selftests: Collect memory access " Colton Lewis
2023-01-17 20:43 ` Ricardo Koller
2023-01-18 16:32 ` Sean Christopherson
2023-01-26 18:00 ` Colton Lewis
2023-01-26 19:07 ` Sean Christopherson
2023-01-26 17:58 ` Colton Lewis
2023-01-26 18:30 ` Ricardo Koller
2023-01-17 20:48 ` Ricardo Koller
2023-01-26 17:59 ` Colton Lewis
2022-11-15 17:32 ` [PATCH 3/3] KVM: selftests: Print summary stats of memory latency distribution Colton Lewis
2023-01-17 20:45 ` Ricardo Koller
2023-01-26 17:58 ` Colton Lewis
2023-01-18 16:43 ` Sean Christopherson
2023-01-26 17:59 ` Colton Lewis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8gjG6gG5UR6T3Yg@google.com \
--to=seanjc@google.com \
--cc=bgardon@google.com \
--cc=coltonlewis@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=ricarkol@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.