From: Sean Christopherson <seanjc@google.com>
To: Alexandru Matei <alexandru.matei@uipath.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Mihai Petrisor <mihai.petrisor@uipath.com>,
Viorel Canja <viorel.canja@uipath.com>
Subject: Re: [PATCH] KVM: VMX: Fix crash due to uninitialized current_vmcs
Date: Wed, 18 Jan 2023 21:35:37 +0000 [thread overview]
Message-ID: <Y8hmKe5ojuqL94ex@google.com> (raw)
In-Reply-To: <ae135ae1-191b-1d58-f12d-38694889664c@uipath.com>
On Wed, Jan 18, 2023, Alexandru Matei wrote:
> On 1/18/2023 6:25 PM, Vitaly Kuznetsov wrote:
> > Oh, indeed, I've forgotten this. I'm fine with 'vmx->vmcs01' then but
> > let's leave a comment (which I've going to also forget about, but still)
> > that eMSR bitmap is an L1-only feature.
> >
> >>
> >> 3. KVM's manipulation of MSR bitmaps typically happens _only_ for vmcs01,
> >> e.g. the caller is vmx_msr_bitmap_l01_changed(). The nested case is a
> >> special snowflake.
> >>
> >
>
> Thanks Sean and Vitaly for your insights and suggestions. I'll redo the patch
> using your code Sean if it's ok with you and run the tests again.
Yep, absolutely! As requested by Vitlay, please also add a comment in
evmcs_touch_msr_bitmap() to call out that the eMSR bitmap is only enabled for L1,
i.e. always operates on (e)vmcs01.
Thanks!
next prev parent reply other threads:[~2023-01-18 21:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 14:13 [PATCH] KVM: VMX: Fix crash due to uninitialized current_vmcs Alexandru Matei
2023-01-18 15:45 ` Sean Christopherson
2023-01-18 16:16 ` Vitaly Kuznetsov
2023-01-18 16:21 ` Sean Christopherson
2023-01-18 16:25 ` Vitaly Kuznetsov
2023-01-18 21:15 ` Alexandru Matei
2023-01-18 21:35 ` Sean Christopherson [this message]
2023-01-18 16:12 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8hmKe5ojuqL94ex@google.com \
--to=seanjc@google.com \
--cc=alexandru.matei@uipath.com \
--cc=kvm@vger.kernel.org \
--cc=mihai.petrisor@uipath.com \
--cc=pbonzini@redhat.com \
--cc=viorel.canja@uipath.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.