Re: tests/qtest: Is vnc-display-test supposed to work on Darwin?

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Jan 19, 2023 at 12:00:41PM +0000, Daniel P. Berrangé wrote:
> On Thu, Jan 19, 2023 at 12:49:48PM +0100, Philippe Mathieu-Daudé wrote:
> > So to detect makecontext() I have to add
> > --extra-cflags=-mmacosx-version-min=10.5 but then linking fails with
> > multiple "$LIBNAME was built for newer macOS version (13.0) than being
> > linked (11.0)".
> 
> Yes, ucontext has been deprecated forever on macOS, but in practice it
> has still been functional if you define _XOPEN_SOURCE, which is what
> gtk-vnc has done traditionally.
> 
> I presume this is on the aarch64 macOS though, and so all bets are off
> wrt ucontext backend unless someone knows it works correctly with the
> m1 port. I fear that's not the case though, given the wierd error
> scenario we're hitting in gtk-vnc.

Yep,  I've confirmed there's something broken with gtk-vnc. When we
call 'getcontext' is corrupts memory in gtk-vnc structs. This makes
me believe that the defined 'struct ucontext_t' is too small for use
with 'getcontext' on macOS aarch64 platforms.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|