From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DD01C678DC for ; Fri, 20 Jan 2023 04:36:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230180AbjATEgX (ORCPT ); Thu, 19 Jan 2023 23:36:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229973AbjATEgC (ORCPT ); Thu, 19 Jan 2023 23:36:02 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 705E3BCE00; Thu, 19 Jan 2023 20:34:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 42380B82485; Thu, 19 Jan 2023 14:25:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75C97C433D2; Thu, 19 Jan 2023 14:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674138317; bh=DOwhtS4jE7pYqDk0EUsW0L6K6Omzw1zbVbFWpn/2xH0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DYHW/AHnm5CgG8wG0DFV9sxNV63AtfcEDCq2VQcjXyzfVLfC2GBQ2Co+oV/bwa4BS RjkR7vSk1NsDek0YKGlUaQusQFpsxv4XtrX2pmHqtTK2GVgCMUSpU06vlAOW/In8MC X0cFueOfUdA8CYH8Cxgi3BQHdG/6LIdnwU3KTECmgHGcAlYmywiUppGVQD2qYnPDm1 yHkKWR75sKDaKUWU4uZZw5zavEa/m/IOBLihr5jiyy+Kj4eBNiUGwOzlwgjTbkt+T8 42c+W2p8W4TvgV/d5oRmD2ac2BJCuHnpVQjz79n/k4IkJXjiofs3NzealJhVWEfnZC UzKnCX+IiQ7qg== Date: Thu, 19 Jan 2023 14:25:12 +0000 From: Lee Jones To: nick.hawkins@hpe.com Cc: verdun@hpe.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/5] ARM: Add GXP I2C Support Message-ID: References: <20230117204439.76841-1-nick.hawkins@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230117204439.76841-1-nick.hawkins@hpe.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Tue, 17 Jan 2023, nick.hawkins@hpe.com wrote: > From: Nick Hawkins > > The GXP SoC supports 10 I2C engines. Each I2C engine is completely > independent and can function both as an I2C master and I2C slave. The > I2C master can operate in a multi master environment. The engines support > a scalable speed from 8kHZ to 1.5 Mhz. > > --- > > Changes since v1: > *Removed yaml documentation of hpe,gxp-sysreg as it has been > applied to syscon.yaml > *Made i2cX a generic node name i2c in dts file > *Added status field to the dtsi and the dts for i2c bus > *Removed unnecessary size-cells and address-cells from yaml > *Removed phandle from hpe,sysreg-phandle > *Changed hpe,i2c-max-bus-freq to clock-frequency > *Removed rogue tab in structure definition > *Removed use of __iomem *base local variables as it was > unnecessary > *Switched #if IS_ENABLED() -> if (IS_ENABLED()) inside > functions > *Removed use of pr_* functions > *Removed informational prints in register and unregister > functions > *Removed print from interrupt handler > *Removed informational prints from probe function > *Switched dev_err -> dev_err_probe in probe function > *Used the respective helper for mapping the resource to > __iomem > > Nick Hawkins (5): > i2c: hpe: Add GXP SoC I2C Controller > dt-bindings: i2c: Add hpe,gxp-i2c > ARM: dts: hpe: Add I2C Topology > ARM: multi_v7_defconfig: add gxp i2c module > MAINTAINERS: Add HPE GXP I2C Support > > .../devicetree/bindings/i2c/hpe,gxp-i2c.yaml | 54 ++ > MAINTAINERS | 2 + > arch/arm/boot/dts/hpe-bmc-dl360gen10.dts | 109 ++++ > arch/arm/boot/dts/hpe-gxp.dtsi | 125 ++++ > arch/arm/configs/multi_v7_defconfig | 1 + > drivers/i2c/busses/Kconfig | 7 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-gxp.c | 609 ++++++++++++++++++ > 8 files changed, 908 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > create mode 100644 drivers/i2c/busses/i2c-gxp.c Not trying to be rude, but why have you sent this to me? -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 160C6C00A5A for ; Thu, 19 Jan 2023 14:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MdRDZTOwYQYUrNgtfWP6DKjJEsMcvHD/uZBDHSj9EfI=; b=4dlBAt0wa5UiSy c5DQwSD6WJZumUhj6cLmdDaQERAq0reWFjXvLIhBpvkH/IApWOcwCkhH28cF6l8ZtpILjcPI1J/Tx jwSJhFD4FY+1OGspb6cHWQ4zHx4XZkv+zJGGdzqvQdnvd5lmP0XBVRM5GnCQ9Q0EmkV24s0Uwr7tr Q2DakFaaSnlLB9s/ufk9+TROGuoIpWqPCxvGJ+4vwBcIJbml2FFAE/LKrbUANzq3QouFoR3CyKTRg HS0F9aut1D4RoaxOQTcvavU4zrFP8ISbQDsqLPAdBMIGDcERY8QB+Fur92akoXdhe6FM6Dn6T3hOx bS609x8s4tAidO7GpLgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIVr2-005ILs-1W; Thu, 19 Jan 2023 14:25:24 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIVqy-005ILC-Ng for linux-arm-kernel@lists.infradead.org; Thu, 19 Jan 2023 14:25:22 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2613FB821F0; Thu, 19 Jan 2023 14:25:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75C97C433D2; Thu, 19 Jan 2023 14:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674138317; bh=DOwhtS4jE7pYqDk0EUsW0L6K6Omzw1zbVbFWpn/2xH0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DYHW/AHnm5CgG8wG0DFV9sxNV63AtfcEDCq2VQcjXyzfVLfC2GBQ2Co+oV/bwa4BS RjkR7vSk1NsDek0YKGlUaQusQFpsxv4XtrX2pmHqtTK2GVgCMUSpU06vlAOW/In8MC X0cFueOfUdA8CYH8Cxgi3BQHdG/6LIdnwU3KTECmgHGcAlYmywiUppGVQD2qYnPDm1 yHkKWR75sKDaKUWU4uZZw5zavEa/m/IOBLihr5jiyy+Kj4eBNiUGwOzlwgjTbkt+T8 42c+W2p8W4TvgV/d5oRmD2ac2BJCuHnpVQjz79n/k4IkJXjiofs3NzealJhVWEfnZC UzKnCX+IiQ7qg== Date: Thu, 19 Jan 2023 14:25:12 +0000 From: Lee Jones To: nick.hawkins@hpe.com Cc: verdun@hpe.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/5] ARM: Add GXP I2C Support Message-ID: References: <20230117204439.76841-1-nick.hawkins@hpe.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230117204439.76841-1-nick.hawkins@hpe.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_062520_938738_D62D83C3 X-CRM114-Status: GOOD ( 19.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxNyBKYW4gMjAyMywgbmljay5oYXdraW5zQGhwZS5jb20gd3JvdGU6Cgo+IEZyb206 IE5pY2sgSGF3a2lucyA8bmljay5oYXdraW5zQGhwZS5jb20+Cj4gCj4gVGhlIEdYUCBTb0Mgc3Vw cG9ydHMgMTAgSTJDIGVuZ2luZXMuIEVhY2ggSTJDIGVuZ2luZSBpcyBjb21wbGV0ZWx5Cj4gaW5k ZXBlbmRlbnQgYW5kIGNhbiBmdW5jdGlvbiBib3RoIGFzIGFuIEkyQyBtYXN0ZXIgYW5kIEkyQyBz bGF2ZS4gVGhlCj4gSTJDIG1hc3RlciBjYW4gb3BlcmF0ZSBpbiBhIG11bHRpIG1hc3RlciBlbnZp cm9ubWVudC4gVGhlIGVuZ2luZXMgc3VwcG9ydAo+IGEgc2NhbGFibGUgc3BlZWQgZnJvbSA4a0ha IHRvIDEuNSBNaHouCj4gCj4gLS0tCj4gCj4gQ2hhbmdlcyBzaW5jZSB2MToKPiAgKlJlbW92ZWQg eWFtbCBkb2N1bWVudGF0aW9uIG9mIGhwZSxneHAtc3lzcmVnIGFzIGl0IGhhcyBiZWVuCj4gICBh cHBsaWVkIHRvIHN5c2Nvbi55YW1sCj4gICpNYWRlIGkyY1ggYSBnZW5lcmljIG5vZGUgbmFtZSBp MmMgaW4gZHRzIGZpbGUKPiAgKkFkZGVkIHN0YXR1cyBmaWVsZCB0byB0aGUgZHRzaSBhbmQgdGhl IGR0cyBmb3IgaTJjIGJ1cwo+ICAqUmVtb3ZlZCB1bm5lY2Vzc2FyeSBzaXplLWNlbGxzIGFuZCBh ZGRyZXNzLWNlbGxzIGZyb20geWFtbAo+ICAqUmVtb3ZlZCBwaGFuZGxlIGZyb20gaHBlLHN5c3Jl Zy1waGFuZGxlCj4gICpDaGFuZ2VkIGhwZSxpMmMtbWF4LWJ1cy1mcmVxIHRvIGNsb2NrLWZyZXF1 ZW5jeQo+ICAqUmVtb3ZlZCByb2d1ZSB0YWIgaW4gc3RydWN0dXJlIGRlZmluaXRpb24KPiAgKlJl bW92ZWQgdXNlIG9mIF9faW9tZW0gKmJhc2UgbG9jYWwgdmFyaWFibGVzIGFzIGl0IHdhcwo+ICAg dW5uZWNlc3NhcnkKPiAgKlN3aXRjaGVkICNpZiBJU19FTkFCTEVEKCkgLT4gaWYgKElTX0VOQUJM RUQoKSkgaW5zaWRlCj4gICBmdW5jdGlvbnMKPiAgKlJlbW92ZWQgdXNlIG9mIHByXyogZnVuY3Rp b25zCj4gICpSZW1vdmVkIGluZm9ybWF0aW9uYWwgcHJpbnRzIGluIHJlZ2lzdGVyIGFuZCB1bnJl Z2lzdGVyCj4gICBmdW5jdGlvbnMKPiAgKlJlbW92ZWQgcHJpbnQgZnJvbSBpbnRlcnJ1cHQgaGFu ZGxlcgo+ICAqUmVtb3ZlZCBpbmZvcm1hdGlvbmFsIHByaW50cyBmcm9tIHByb2JlIGZ1bmN0aW9u Cj4gICpTd2l0Y2hlZCBkZXZfZXJyIC0+IGRldl9lcnJfcHJvYmUgaW4gcHJvYmUgZnVuY3Rpb24K PiAgKlVzZWQgdGhlIHJlc3BlY3RpdmUgaGVscGVyIGZvciBtYXBwaW5nIHRoZSByZXNvdXJjZSB0 bwo+ICAgX19pb21lbQo+IAo+IE5pY2sgSGF3a2lucyAoNSk6Cj4gICBpMmM6IGhwZTogQWRkIEdY UCBTb0MgSTJDIENvbnRyb2xsZXIKPiAgIGR0LWJpbmRpbmdzOiBpMmM6IEFkZCBocGUsZ3hwLWky Ywo+ICAgQVJNOiBkdHM6IGhwZTogQWRkIEkyQyBUb3BvbG9neQo+ICAgQVJNOiBtdWx0aV92N19k ZWZjb25maWc6IGFkZCBneHAgaTJjIG1vZHVsZQo+ICAgTUFJTlRBSU5FUlM6IEFkZCBIUEUgR1hQ IEkyQyBTdXBwb3J0Cj4gCj4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL2kyYy9ocGUsZ3hwLWky Yy55YW1sICB8ICA1NCArKwo+ICBNQUlOVEFJTkVSUyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgfCAgIDIgKwo+ICBhcmNoL2FybS9ib290L2R0cy9ocGUtYm1jLWRsMzYwZ2VuMTAu ZHRzICAgICAgfCAxMDkgKysrKwo+ICBhcmNoL2FybS9ib290L2R0cy9ocGUtZ3hwLmR0c2kgICAg ICAgICAgICAgICAgfCAxMjUgKysrKwo+ICBhcmNoL2FybS9jb25maWdzL211bHRpX3Y3X2RlZmNv bmZpZyAgICAgICAgICAgfCAgIDEgKwo+ICBkcml2ZXJzL2kyYy9idXNzZXMvS2NvbmZpZyAgICAg ICAgICAgICAgICAgICAgfCAgIDcgKwo+ICBkcml2ZXJzL2kyYy9idXNzZXMvTWFrZWZpbGUgICAg ICAgICAgICAgICAgICAgfCAgIDEgKwo+ICBkcml2ZXJzL2kyYy9idXNzZXMvaTJjLWd4cC5jICAg ICAgICAgICAgICAgICAgfCA2MDkgKysrKysrKysrKysrKysrKysrCj4gIDggZmlsZXMgY2hhbmdl ZCwgOTA4IGluc2VydGlvbnMoKykKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9pMmMvaHBlLGd4cC1pMmMueWFtbAo+ICBjcmVhdGUgbW9kZSAx MDA2NDQgZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1neHAuYwoKTm90IHRyeWluZyB0byBiZSBydWRl LCBidXQgd2h5IGhhdmUgeW91IHNlbnQgdGhpcyB0byBtZT8KCi0tIApMZWUgSm9uZXMgW+adjueQ vOaWr10KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK