All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Daniel Scally <djrscally@gmail.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH v4 1/4] device property: Get rid of __PROPERTY_ENTRY_ARRAY_EL*SIZE*()
Date: Thu, 19 Jan 2023 17:46:59 +0200	[thread overview]
Message-ID: <Y8ll89pF8MJhI1WA@smile.fi.intel.com> (raw)
In-Reply-To: <Y8lkhedIFY8UOPf+@kroah.com>

On Thu, Jan 19, 2023 at 04:40:53PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Nov 23, 2022 at 07:55:44PM +0100, Rafael J. Wysocki wrote:
> > On Tue, Nov 22, 2022 at 2:35 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > First of all, _ELEMENT_SIZE() repeats existing sizeof_field() macro.
> > > Second, usage of _ARRAY_ELSIZE_LEN() adds unnecessary indirection
> > > to the data layout. It's more understandable when the data structure
> > > is placed explicitly. That said, get rid of those macros by replacing
> > > them with the existing helper and explicit data structure layout.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > 
> > The series in which this patch is included does not apply cleanly for me.
> > 
> > I guess it depends on the earlier material already in Greg's tree, so
> > I'm leaving it to Greg.
> 
> Andy, did I miss this?

Nope, thanks!
40eb28dc17f8 ("device property: Get rid of __PROPERTY_ENTRY_ARRAY_EL*SIZE*()")

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2023-01-19 15:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 13:35 [PATCH v4 1/4] device property: Get rid of __PROPERTY_ENTRY_ARRAY_EL*SIZE*() Andy Shevchenko
2022-11-22 13:35 ` [PATCH v4 2/4] device property: Move PROPERTY_ENTRY_BOOL() a bit down Andy Shevchenko
2022-11-22 13:35 ` [PATCH v4 3/4] device property: Rename goto label to be more precise Andy Shevchenko
2022-11-22 13:36 ` [PATCH v4 4/4] device property: Add a blank line in Kconfig of tests Andy Shevchenko
2022-11-23 18:55 ` [PATCH v4 1/4] device property: Get rid of __PROPERTY_ENTRY_ARRAY_EL*SIZE*() Rafael J. Wysocki
2023-01-19 15:40   ` Greg Kroah-Hartman
2023-01-19 15:46     ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8ll89pF8MJhI1WA@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=djrscally@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.