From: Oliver Upton <oliver.upton@linux.dev>
To: Yu Zhang <yu.c.zhang@linux.intel.com>
Cc: Sean Christopherson <seanjc@google.com>,
kvm@vger.kernel.org, pbonzini@redhat.com, maz@kernel.org,
james.morse@arm.com, alexandru.elisei@arm.com,
suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org,
paul@xen.org
Subject: Re: [PATCH v5] KVM: MMU: Make the definition of 'INVALID_GPA' common
Date: Thu, 19 Jan 2023 18:22:32 +0000 [thread overview]
Message-ID: <Y8mKaBgzDmtj2rtK@google.com> (raw)
In-Reply-To: <20230119072556.ebnddkr54vqbzmjk@linux.intel.com>
On Thu, Jan 19, 2023 at 03:25:56PM +0800, Yu Zhang wrote:
> On Thu, Jan 19, 2023 at 12:53:36AM +0000, Sean Christopherson wrote:
> > On Thu, Jan 05, 2023, Yu Zhang wrote:
> > > KVM already has a 'GPA_INVALID' defined as (~(gpa_t)0) in kvm_types.h,
> > > and it is used by ARM code. We do not need another definition of
> > > 'INVALID_GPA' for X86 specifically.
> > >
> > > Instead of using the common 'GPA_INVALID' for X86, replace it with
> > > 'INVALID_GPA', and change the users of 'GPA_INVALID' so that the diff
> > > can be smaller. Also because the name 'INVALID_GPA' tells the user we
> > > are using an invalid GPA, while the name 'GPA_INVALID' is emphasizing
> > > the GPA is an invalid one.
> > >
> > > No functional change intended.
> > >
> > > Signed-off-by: Yu Zhang <yu.c.zhang@linux.intel.com>
> > > Reviewed-by: Paul Durrant <paul@xen.org>
> > > Reviewed-by: Sean Christopherson <seanjc@google.com>
> > > ---
> >
> > Marc and/or Oliver,
> >
> > Do you want to grab this since most of the changes are to arm64? I'll happily
> > take it through x86, but generating a conflict in arm64 seems infinitely more likely.
> >
> Thank you, Sean!
>
> This patch was based on KVM's next branch - fc471e831016c ("Merge branch 'kvm-late-6.1'
> into HEAD"). Tested by cross-building arm64.
>
> Do you know if KVM arm use a seperate branch(or repo)? Thanks!
Yes, you can find us over here:
https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git/
I'll grab this after I wrap up testing what I have so far.
--
Thanks,
Oliver
next prev parent reply other threads:[~2023-01-19 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 13:01 [PATCH v5] KVM: MMU: Make the definition of 'INVALID_GPA' common Yu Zhang
2023-01-19 0:53 ` Sean Christopherson
2023-01-19 7:25 ` Yu Zhang
2023-01-19 18:22 ` Oliver Upton [this message]
2023-01-19 9:54 ` Marc Zyngier
2023-01-19 9:56 ` Marc Zyngier
2023-01-30 19:15 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8mKaBgzDmtj2rtK@google.com \
--to=oliver.upton@linux.dev \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yu.c.zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.