From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B37FB43E for ; Thu, 19 Jan 2023 19:38:12 +0000 (UTC) Date: Thu, 19 Jan 2023 19:38:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1674157085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H6H/+GrpC5ozTA0QyGnONZD4lm6LEL1WMI8opKr9p4U=; b=rLcXA9s8GMAEiuzs/GY0vRCq7owrSN043xwnUr2oJMiLfJUP82mSjFyYqA9+bYcdG1mD9h +WRueuBGjYyziSUaDRoJyCIpJe/hTSUPqqxjcQ7Diq8O9q4W9vC4LTokGs7K+cVVU4RSRV B2BmYr2z5WjMx1pDjt47/SlfvHiCo0o= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Catalin Marinas Cc: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH] KVM: arm64: Pass the actual page address to mte_clear_page_tags() Message-ID: References: <20230119170902.1574756-1-catalin.marinas@arm.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119170902.1574756-1-catalin.marinas@arm.com> X-Migadu-Flow: FLOW_OUT On Thu, Jan 19, 2023 at 05:09:02PM +0000, Catalin Marinas wrote: > Commit d77e59a8fccd ("arm64: mte: Lock a page for MTE tag > initialisation") added a call to mte_clear_page_tags() in case a > prior mte_copy_tags_from_user() failed in order to avoid stale tags in > the guest page (it should have really been a separate commit). > Unfortunately, the argument passed to this function was the address of > the struct page rather than the actual page address. Fix this function > call. > > Fixes: d77e59a8fccd ("arm64: mte: Lock a page for MTE tag initialisation") > Signed-off-by: Catalin Marinas > Cc: Marc Zyngier Yikes, looks like we should pick this up for 6.2. Reviewed-by: Oliver Upton -- Thanks, Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21484C46467 for ; Thu, 19 Jan 2023 19:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=74wbkloBlwiZ6GyD65evmXlC0pD5hf4NaNNUbsPd01g=; b=QgmJzyL/HS+qxD d+X5DICUdLYSSOwcX92+v1JAQ/9paPMabBd3JuEqfKwDFli/rkFMCdh44+FEsjpX2F6u83hVKmrnw tb/1s65DpFwXD2Lvu1Cg5GC30F4GDWPkLjKvY1iwoOkyfGCPqlM3MxedzrPv9jnPtv2kgehcgUZVm fumRc/317zTl7O+fFXPpMzBvjDSnOUsNMMSJTcs9lSWzla6ylapGbu4OR4WzCWnd3p1mfjXOidxiO mdN2/Un7W/eFVneVrgmVMvZW5+yIgPwNHDXMx4DFYdYZZQQghvLoRvRxHgA72ya6ySU9tXZo+rjE1 elrN7ZXvEc8Lw3whOSfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIajs-0070Ro-6M; Thu, 19 Jan 2023 19:38:20 +0000 Received: from out0.migadu.com ([94.23.1.103]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIajn-0070MX-2p for linux-arm-kernel@lists.infradead.org; Thu, 19 Jan 2023 19:38:17 +0000 Date: Thu, 19 Jan 2023 19:38:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1674157085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H6H/+GrpC5ozTA0QyGnONZD4lm6LEL1WMI8opKr9p4U=; b=rLcXA9s8GMAEiuzs/GY0vRCq7owrSN043xwnUr2oJMiLfJUP82mSjFyYqA9+bYcdG1mD9h +WRueuBGjYyziSUaDRoJyCIpJe/hTSUPqqxjcQ7Diq8O9q4W9vC4LTokGs7K+cVVU4RSRV B2BmYr2z5WjMx1pDjt47/SlfvHiCo0o= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Catalin Marinas Cc: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH] KVM: arm64: Pass the actual page address to mte_clear_page_tags() Message-ID: References: <20230119170902.1574756-1-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230119170902.1574756-1-catalin.marinas@arm.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_113816_257024_EE5233DB X-CRM114-Status: GOOD ( 10.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 19, 2023 at 05:09:02PM +0000, Catalin Marinas wrote: > Commit d77e59a8fccd ("arm64: mte: Lock a page for MTE tag > initialisation") added a call to mte_clear_page_tags() in case a > prior mte_copy_tags_from_user() failed in order to avoid stale tags in > the guest page (it should have really been a separate commit). > Unfortunately, the argument passed to this function was the address of > the struct page rather than the actual page address. Fix this function > call. > > Fixes: d77e59a8fccd ("arm64: mte: Lock a page for MTE tag initialisation") > Signed-off-by: Catalin Marinas > Cc: Marc Zyngier Yikes, looks like we should pick this up for 6.2. Reviewed-by: Oliver Upton -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel