From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7F55C25B4E for ; Fri, 20 Jan 2023 12:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zTIahO9hvIwIm5dGcPw4BQlGkI3WbTKYyIPyay6qtEo=; b=WRXOc+qELQojfP ncSzdi7cBhr5I+OSHEG+9gd61IETdTDkAcN/gXBTpjYy9Y4ZFSwsz3rwNfIrq2qWROcKqAOFJxxW+ vfqj1AJtMRQmD4k9na/6+zYjX+SQJNCTIsjwGO301Y+iMSdWuxSPq8RvkWnTz+sWjuCQgqqXRaFe8 CvLAfJkF/kj41njU+OCgHLwbrCMW3uKG90JpdQTOWHSmiLh3oBbUFF5tS40VEu4AH7ZrW1qf5+KB0 OqTYl6lKv47hUtgntIUNHa8XI49AGmjwQe0uz9Z9ZiZuf2T3G45U7JZUotBwN4c6eFDAzSThS8a5y XnnYJj1DJc5eB16AbVcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIqhb-00AIX0-No; Fri, 20 Jan 2023 12:41:03 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIqhY-00AIW3-MK for linux-arm-kernel@lists.infradead.org; Fri, 20 Jan 2023 12:41:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pyOudyZE6Qr771b7j4P3nM+U18vAd7SY7miShs5OpoI=; b=DE+FI8C9ClIbgVkc+UVRBQIVHm UeErTJzkMuMECuVgG5Dj/JTc5PgNox2XJOWsSvKxy21ib2vOiQi3CXYBGUAYkA7BxYn0zFAeirTnj As2ETkWKz4SfZHVR1wUzhmizzRaUy4eWxMw8U1ZAPn93COrd961lZSIXSVKRwyZgV5zl2KdmFmoYB pS9q+MWTiXrwUHJwiYBUG0QzXnQiPwjehcUde7aQyg32rTiN1AO7+OLPp5LUqxqp4q/x+VnpSnYtQ rsUkMVJiy6bjfLTt0aBqUStNXalZMMRK88OXUl79t87DcOJDjO9DhF3zazLhaJ355jwSgJDJr8E/S sa+Hz6uA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36230) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pIqhR-0006h6-Tw; Fri, 20 Jan 2023 12:40:53 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pIqhP-0001Sk-PQ; Fri, 20 Jan 2023 12:40:51 +0000 Date: Fri, 20 Jan 2023 12:40:51 +0000 From: "Russell King (Oracle)" To: Suzuki K Poulose Cc: Steve Clevenger , mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] coresight etm4x: Add pr_debug statement for Coresight component PID/CID Message-ID: References: <025786de-5064-fdb5-b679-17e74fc92878@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <025786de-5064-fdb5-b679-17e74fc92878@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230120_044100_770862_E9FDD9D4 X-CRM114-Status: GOOD ( 16.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 20, 2023 at 11:23:53AM +0000, Suzuki K Poulose wrote: > > Cc: Russell > > nit: Subject line doesn't match the patch. This could be : > > "amba: bus: Add pr_debug for AMBA PID/CID" > > On 20/01/2023 00:51, Steve Clevenger wrote: > > Add pr_debug statement to provide visibility into Coresight component PID > > and CID settings. This helped debug an intermittent clock related issue > > resulting in bad PID/CID values. > > And this change belongs to the AMBA subsystem. Please run : > > scripts/get_maintainer.pl on your patch and add the necessary people from > that list for your patch. > > As such, I don't think brings any value to be added to the tree. > I will leave it for the maintainers to comment. Looking at the context in this patch, I see code that is reading at least the CID but likely also the PID from the device, duplicating the code that is already in the bus layer, and stored in the amba_device's periphid and cid members... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel