From: Simon Horman <simon.horman@corigine.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-wireless@vger.kernel.org, tony0620emma@gmail.com,
kvalo@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Neo Jou <neojou@gmail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
pkshih@realtek.com
Subject: Re: [PATCH v2 1/4] wifi: rtw88: pci: Use enum type for rtw_hw_queue_mapping() and ac_to_hwq
Date: Sun, 5 Feb 2023 14:37:16 +0100 [thread overview]
Message-ID: <Y9+xDKZvQdNnbdxA@corigine.com> (raw)
In-Reply-To: <20230204233001.1511643-2-martin.blumenstingl@googlemail.com>
On Sun, Feb 05, 2023 at 12:29:58AM +0100, Martin Blumenstingl wrote:
> rtw_hw_queue_mapping() and ac_to_hwq[] hold values of type enum
> rtw_tx_queue_type. Change their types to reflect this to make it easier
> to understand this part of the code.
>
> While here, also change the array to be static const as it is not
> supposed to be modified at runtime.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-02-05 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 23:29 [PATCH v2 0/4] rtw88: four small code-cleanups and refactorings Martin Blumenstingl
2023-02-04 23:29 ` [PATCH v2 1/4] wifi: rtw88: pci: Use enum type for rtw_hw_queue_mapping() and ac_to_hwq Martin Blumenstingl
2023-02-05 13:37 ` Simon Horman [this message]
2023-02-08 0:27 ` Ping-Ke Shih
2023-02-13 15:16 ` Kalle Valo
2023-02-04 23:29 ` [PATCH v2 2/4] wifi: rtw88: pci: Change queue datatype to enum rtw_tx_queue_type Martin Blumenstingl
2023-02-05 13:37 ` Simon Horman
2023-02-04 23:30 ` [PATCH v2 3/4] wifi: rtw88: Move enum rtw_tx_queue_type mapping code to tx.{c,h} Martin Blumenstingl
2023-02-05 13:39 ` Simon Horman
2023-02-08 0:29 ` Ping-Ke Shih
2023-02-04 23:30 ` [PATCH v2 4/4] wifi: rtw88: mac: Use existing macros in rtw_pwr_seq_parser() Martin Blumenstingl
2023-02-05 13:40 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9+xDKZvQdNnbdxA@corigine.com \
--to=simon.horman@corigine.com \
--cc=jernej.skrabec@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neojou@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.