From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B794AC61DA4 for ; Fri, 3 Feb 2023 20:15:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233096AbjBCUPg (ORCPT ); Fri, 3 Feb 2023 15:15:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231302AbjBCUPf (ORCPT ); Fri, 3 Feb 2023 15:15:35 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8F8891882; Fri, 3 Feb 2023 12:15:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5F6B6B82BB2; Fri, 3 Feb 2023 20:15:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB01AC433D2; Fri, 3 Feb 2023 20:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675455332; bh=3wRIsEkcYgnxR1oUaUKFTnjvlPLYKjDerxB/b+desAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XNrPSl5X5PzDmjlWqVQxEf/PMr/4ad/lJjFiZ6RNo5iwLeo+5hLoltqMLjhtHFFw6 qQQlqqvcLDoIoDCaBqkP6r9mhyYAH3LHCraBq0fiARVl8x5oRUEL3YpoAOoAR04XF4 hpCOTi2f+OgVUr3mHrZIl5vInJdziv28q6CYJdz/AdSq+jlUlFLQ0O0WWwUFWHYugQ erEHNa7QPVdrTZHJSa72QYsUV/SvJYa3dOE7lY45VVXMOoSvKudhFEzc8SFH0oz/0x anhhPBjyETEGVTuu/MXVpxJbSSBJs8F/BYYaEwtoUtLewLzX7phfFxmnaSYa5M9FOC JgDZ9BCDXyt+A== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 35877405BE; Fri, 3 Feb 2023 17:15:29 -0300 (-03) Date: Fri, 3 Feb 2023 17:15:29 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Kim Phillips , Florian Fischer , Ravi Bangoria , Xing Zhengjun , Rob Herring , Kang Minchul , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Sandipan Das , Jing Zhang , linuxppc-dev@lists.ozlabs.org, Kajol Jain , Stephane Eranian , Perry Taylor , Caleb Biggers Subject: Re: [PATCH v5 15/15] perf jevents: Run metric_test.py at compile-time Message-ID: References: <20230126233645.200509-1-irogers@google.com> <20230126233645.200509-16-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230126233645.200509-16-irogers@google.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Thu, Jan 26, 2023 at 03:36:45PM -0800, Ian Rogers escreveu: > Add a target that generates a log file for running metric_test.py and > make this a dependency on generating pmu-events.c. The log output is > displayed if the test fails like (the test was modified to make it > fail): > > ``` > TEST /tmp/perf/pmu-events/metric_test.log > F...... > ====================================================================== > FAIL: test_Brackets (__main__.TestMetricExpressions) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "tools/perf/pmu-events/metric_test.py", line 33, in test_Brackets > self.assertEqual((a * b + c).ToPerfJson(), 'a * b + d') > AssertionError: 'a * b + c' != 'a * b + d' > - a * b + c > ? ^ > + a * b + d Added this: diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore index 05806ecfc33c12a1..f533e76fb48002b7 100644 --- a/tools/perf/.gitignore +++ b/tools/perf/.gitignore @@ -38,6 +38,7 @@ arch/*/include/generated/ trace/beauty/generated/ pmu-events/pmu-events.c pmu-events/jevents +pmu-events/metric_test.log feature/ libapi/ libbpf/ diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index b7d9c42062300d04..bac9272682b759e9 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -1103,6 +1103,7 @@ clean:: $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBSYMBOL)-clean $( $(OUTPUT)util/intel-pt-decoder/inat-tables.c \ $(OUTPUT)tests/llvm-src-{base,kbuild,prologue,relocation}.c \ $(OUTPUT)pmu-events/pmu-events.c \ + $(OUTPUT)pmu-events/metric_test.log \ $(OUTPUT)$(fadvise_advice_array) \ $(OUTPUT)$(fsconfig_arrays) \ $(OUTPUT)$(fsmount_arrays) \ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3087CC61DA4 for ; Fri, 3 Feb 2023 20:16:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4P7n421pW6z3f8n for ; Sat, 4 Feb 2023 07:16:34 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=XNrPSl5X; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=acme@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=XNrPSl5X; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4P7n2y03t8z3f6B for ; Sat, 4 Feb 2023 07:15:37 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4EC89B82BA4; Fri, 3 Feb 2023 20:15:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB01AC433D2; Fri, 3 Feb 2023 20:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675455332; bh=3wRIsEkcYgnxR1oUaUKFTnjvlPLYKjDerxB/b+desAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XNrPSl5X5PzDmjlWqVQxEf/PMr/4ad/lJjFiZ6RNo5iwLeo+5hLoltqMLjhtHFFw6 qQQlqqvcLDoIoDCaBqkP6r9mhyYAH3LHCraBq0fiARVl8x5oRUEL3YpoAOoAR04XF4 hpCOTi2f+OgVUr3mHrZIl5vInJdziv28q6CYJdz/AdSq+jlUlFLQ0O0WWwUFWHYugQ erEHNa7QPVdrTZHJSa72QYsUV/SvJYa3dOE7lY45VVXMOoSvKudhFEzc8SFH0oz/0x anhhPBjyETEGVTuu/MXVpxJbSSBJs8F/BYYaEwtoUtLewLzX7phfFxmnaSYa5M9FOC JgDZ9BCDXyt+A== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 35877405BE; Fri, 3 Feb 2023 17:15:29 -0300 (-03) Date: Fri, 3 Feb 2023 17:15:29 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Subject: Re: [PATCH v5 15/15] perf jevents: Run metric_test.py at compile-time Message-ID: References: <20230126233645.200509-1-irogers@google.com> <20230126233645.200509-16-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230126233645.200509-16-irogers@google.com> X-Url: http://acmel.wordpress.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kang Minchul , Sandipan Das , Peter Zijlstra , Perry Taylor , Stephane Eranian , linux-kernel@vger.kernel.org, James Clark , Kim Phillips , Will Deacon , Kan Liang , Rob Herring , Alexander Shishkin , Ingo Molnar , Xing Zhengjun , Mike Leach , John Garry , Kajol Jain , Namhyung Kim , Caleb Biggers , linux-arm-kernel@lists.infradead.org, Ravi Bangoria , Florian Fischer , Adrian Hunter , linux-perf-users@vger.kernel.org, Jiri Olsa , Leo Yan , linuxppc-dev@lists.ozlabs.org, Jing Zhang Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Em Thu, Jan 26, 2023 at 03:36:45PM -0800, Ian Rogers escreveu: > Add a target that generates a log file for running metric_test.py and > make this a dependency on generating pmu-events.c. The log output is > displayed if the test fails like (the test was modified to make it > fail): > > ``` > TEST /tmp/perf/pmu-events/metric_test.log > F...... > ====================================================================== > FAIL: test_Brackets (__main__.TestMetricExpressions) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "tools/perf/pmu-events/metric_test.py", line 33, in test_Brackets > self.assertEqual((a * b + c).ToPerfJson(), 'a * b + d') > AssertionError: 'a * b + c' != 'a * b + d' > - a * b + c > ? ^ > + a * b + d Added this: diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore index 05806ecfc33c12a1..f533e76fb48002b7 100644 --- a/tools/perf/.gitignore +++ b/tools/perf/.gitignore @@ -38,6 +38,7 @@ arch/*/include/generated/ trace/beauty/generated/ pmu-events/pmu-events.c pmu-events/jevents +pmu-events/metric_test.log feature/ libapi/ libbpf/ diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index b7d9c42062300d04..bac9272682b759e9 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -1103,6 +1103,7 @@ clean:: $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBSYMBOL)-clean $( $(OUTPUT)util/intel-pt-decoder/inat-tables.c \ $(OUTPUT)tests/llvm-src-{base,kbuild,prologue,relocation}.c \ $(OUTPUT)pmu-events/pmu-events.c \ + $(OUTPUT)pmu-events/metric_test.log \ $(OUTPUT)$(fadvise_advice_array) \ $(OUTPUT)$(fsconfig_arrays) \ $(OUTPUT)$(fsmount_arrays) \ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDC4FC61DA4 for ; Fri, 3 Feb 2023 20:16:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ok7W+8usLUObLt7Bw4k/lN/fMRhqs5mG5jHthf6JePo=; b=XPocegMRPSLCr0 V4gkxucMRKnDvwd5ZTIJRscLwx4vs02PN5VDlPSZo/VlwTqrT6IZmyY3XAR6hCpQ+ne3YtAzdLn+1 p9pcGLWns6jLlIMzX2xxF9LEon562gs+gREluXZqJjLTLMU4Eig32Ogl5JhmhGtoMIdYtGvb4oJgR wlQI5BTWMvntL5FWZjC/nmYdeQCbJd3KsI6aoz9YB/sMEbQtV5uZCBfgwn1KWL6XwXTYOgC0qbM70 0Zf5MmWAHPj6QwfgkNgMKv1ODZpkyZfvVMTek29wcn8VjS+hnhbPp9aJ1B7MgK8aV9Imw5qeMGhq3 jvB3LtVg2YDqGHk1HJPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pO2TB-003T80-Qc; Fri, 03 Feb 2023 20:15:37 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pO2T9-003T7o-CT for linux-arm-kernel@bombadil.infradead.org; Fri, 03 Feb 2023 20:15:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4a4Ka4xsSf5XU6vkM/AiYUWyRSpT3MpPv4GR/Da9C7g=; b=Tl4FPoA8yGinAJD6Ib69jrcYUM S7pl0VX+dw3CTFrCIe8mdaBJ4FkNryAXZK8WXY7+ES6vcqXA3o0sQ99EfX3Fx4xEqS4o1OPMzmAqc 6e+JW8Ld7HzFGkjEl1I3gX/i9x21Gjgr8FyLk2oZvcgCnXeGwBWL7PsAtd2xO5oClGVuqEhX8VKDO bTnYHBU6Ir1VSNGoh+6AdZigm092nlvxzGGrJkHW0LlKGc8Rr4OEopV+PQyvzZh+61jARTtAPo3HC AxKo1NWVoy14dN/TTCFzBEpJfcNTOZoULNgDH95D26OuzhSeZDDipo0N6SvGe8rKhXpECShwvu3gA H0K3t4uQ==; Received: from [187.19.237.165] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pO2T7-00Ebb5-3K; Fri, 03 Feb 2023 20:15:33 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 35877405BE; Fri, 3 Feb 2023 17:15:29 -0300 (-03) Date: Fri, 3 Feb 2023 17:15:29 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Kim Phillips , Florian Fischer , Ravi Bangoria , Xing Zhengjun , Rob Herring , Kang Minchul , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Sandipan Das , Jing Zhang , linuxppc-dev@lists.ozlabs.org, Kajol Jain , Stephane Eranian , Perry Taylor , Caleb Biggers Subject: Re: [PATCH v5 15/15] perf jevents: Run metric_test.py at compile-time Message-ID: References: <20230126233645.200509-1-irogers@google.com> <20230126233645.200509-16-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230126233645.200509-16-irogers@google.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Thu, Jan 26, 2023 at 03:36:45PM -0800, Ian Rogers escreveu: > Add a target that generates a log file for running metric_test.py and > make this a dependency on generating pmu-events.c. The log output is > displayed if the test fails like (the test was modified to make it > fail): > > ``` > TEST /tmp/perf/pmu-events/metric_test.log > F...... > ====================================================================== > FAIL: test_Brackets (__main__.TestMetricExpressions) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "tools/perf/pmu-events/metric_test.py", line 33, in test_Brackets > self.assertEqual((a * b + c).ToPerfJson(), 'a * b + d') > AssertionError: 'a * b + c' != 'a * b + d' > - a * b + c > ? ^ > + a * b + d Added this: diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore index 05806ecfc33c12a1..f533e76fb48002b7 100644 --- a/tools/perf/.gitignore +++ b/tools/perf/.gitignore @@ -38,6 +38,7 @@ arch/*/include/generated/ trace/beauty/generated/ pmu-events/pmu-events.c pmu-events/jevents +pmu-events/metric_test.log feature/ libapi/ libbpf/ diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index b7d9c42062300d04..bac9272682b759e9 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -1103,6 +1103,7 @@ clean:: $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBSYMBOL)-clean $( $(OUTPUT)util/intel-pt-decoder/inat-tables.c \ $(OUTPUT)tests/llvm-src-{base,kbuild,prologue,relocation}.c \ $(OUTPUT)pmu-events/pmu-events.c \ + $(OUTPUT)pmu-events/metric_test.log \ $(OUTPUT)$(fadvise_advice_array) \ $(OUTPUT)$(fsconfig_arrays) \ $(OUTPUT)$(fsmount_arrays) \ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel