From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Wolfram Sang" <wsa@kernel.org>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Matti Vaittinen" <Matti.Vaittinen@fi.rohmeurope.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Peter Rosin" <peda@axentia.se>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Michael Tretter" <m.tretter@pengutronix.de>,
"Shawn Tu" <shawnx.tu@intel.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Mike Pagano" <mpagano@gentoo.org>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Marek Vasut" <marex@denx.de>,
"Satish Nagireddy" <satish.nagireddy@getcruise.com>
Subject: Re: [PATCH v8 5/7] media: i2c: add DS90UB960 driver
Date: Wed, 25 Jan 2023 13:41:38 +0200 [thread overview]
Message-ID: <Y9EVcktGPabqYw+q@smile.fi.intel.com> (raw)
In-Reply-To: <Y9EAw+PUwZJFH+NO@pendragon.ideasonboard.com>
On Wed, Jan 25, 2023 at 12:13:23PM +0200, Laurent Pinchart wrote:
> On Wed, Jan 25, 2023 at 09:39:57AM +0200, Tomi Valkeinen wrote:
...
> I find
>
> dev_dbg(dev, read_err_str, port, "ti,cdr-mode", ret);
>
> less readable as I then have to look up the read_err_str string to
> understand that line. I also wonder, in that case, if the compiler can
> still warn if the format string doesn't match the argument types.
Sorry to be a bit offtopic, but this argument is exactly what I'm trying
to tell Sakari when reviewing some other series.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-25 11:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 15:34 [PATCH v8 0/7] i2c-atr and FPDLink Tomi Valkeinen
2023-01-20 15:34 ` [PATCH v8 1/7] i2c: add I2C Address Translator (ATR) support Tomi Valkeinen
2023-01-20 15:34 ` [PATCH v8 2/7] dt-bindings: media: add TI DS90UB913 FPD-Link III Serializer Tomi Valkeinen
2023-01-20 15:34 ` [PATCH v8 3/7] dt-bindings: media: add TI DS90UB953 " Tomi Valkeinen
2023-01-20 15:34 ` [PATCH v8 4/7] dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer Tomi Valkeinen
2023-01-20 15:34 ` [PATCH v8 5/7] media: i2c: add DS90UB960 driver Tomi Valkeinen
2023-01-23 22:04 ` Laurent Pinchart
2023-01-24 14:48 ` Tomi Valkeinen
2023-01-24 18:27 ` Laurent Pinchart
2023-01-25 7:39 ` Tomi Valkeinen
2023-01-25 10:13 ` Laurent Pinchart
2023-01-25 11:34 ` Tomi Valkeinen
2023-01-25 11:41 ` Andy Shevchenko [this message]
2023-01-20 15:34 ` [PATCH v8 6/7] media: i2c: add DS90UB913 driver Tomi Valkeinen
2023-01-20 15:34 ` [PATCH v8 7/7] media: i2c: add DS90UB953 driver Tomi Valkeinen
2023-01-20 15:37 ` [PATCH v8 0/7] i2c-atr and FPDLink Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9EVcktGPabqYw+q@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=khalasa@piap.pl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.tretter@pengutronix.de \
--cc=marex@denx.de \
--cc=mchehab@kernel.org \
--cc=mpagano@gentoo.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=satish.nagireddy@getcruise.com \
--cc=shawnx.tu@intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.