From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 4.14] comedi: adv_pci1760: Fix PWM instruction handling
Date: Wed, 25 Jan 2023 17:51:43 +0100 [thread overview]
Message-ID: <Y9FeH6iOxyDsEdw2@kroah.com> (raw)
In-Reply-To: <20230123103641.9000-1-abbotti@mev.co.uk>
On Mon, Jan 23, 2023 at 10:36:41AM +0000, Ian Abbott wrote:
> commit 2efb6edd52dc50273f5e68ad863dd1b1fb2f2d1c upstream.
>
> (Actually, this is fixing the "Read the Current Status" command sent to
> the device's outgoing mailbox, but it is only currently used for the PWM
> instructions.)
>
> The PCI-1760 is operated mostly by sending commands to a set of Outgoing
> Mailbox registers, waiting for the command to complete, and reading the
> result from the Incoming Mailbox registers. One of these commands is
> the "Read the Current Status" command. The number of this command is
> 0x07 (see the User's Manual for the PCI-1760 at
> <https://advdownload.advantech.com/productfile/Downloadfile2/1-11P6653/PCI-1760.pdf>.
> The `PCI1760_CMD_GET_STATUS` macro defined in the driver should expand
> to this command number 0x07, but unfortunately it currently expands to
> 0x03. (Command number 0x03 is not defined in the User's Manual.)
> Correct the definition of the `PCI1760_CMD_GET_STATUS` macro to fix it.
>
> This is used by all the PWM subdevice related instructions handled by
> `pci1760_pwm_insn_config()` which are probably all broken. The effect
> of sending the undefined command number 0x03 is not known.
>
> Fixes: 14b93bb6bbf0 ("staging: comedi: adv_pci_dio: separate out PCI-1760 support")
> Cc: <stable@vger.kernel.org> # v4.5+
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> Link: https://lore.kernel.org/r/20230103143754.17564-1-abbotti@mev.co.uk
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> Should apply OK to v4.5 to v4.18 inclusive. [IA]
Now queued up,t hanks.
greg k-h
prev parent reply other threads:[~2023-01-25 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 10:36 [PATCH 4.14] comedi: adv_pci1760: Fix PWM instruction handling Ian Abbott
2023-01-25 16:51 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9FeH6iOxyDsEdw2@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.