All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v3] i2c: dev: don't allow user-space to deadlock the kernel
Date: Wed, 25 Jan 2023 23:11:59 +0100	[thread overview]
Message-ID: <Y9GpL9RBNM8H2ZSL@shikoro> (raw)
In-Reply-To: <Y9DpbChLZfDONHPz@ninjato>

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]


> So, this code handled all my stress-testing well so far. I'll try to
> think of some more ideas until this evening, but likely I will apply it
> later. Nonetheless, more review eyes are still welcome!

Ah yes, I now recalled why I had the gut feeling that this solution is
not complete. See this mail thread from 2015:

https://lkml.iu.edu/hypermail/linux/kernel/1501.2/01700.html

There are still drivers using i2c_del_adapter()+kfree(), so removing the
completion could cause use-after-free there, or?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-01-25 22:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 13:49 [PATCH v3] i2c: dev: don't allow user-space to deadlock the kernel Bartosz Golaszewski
2023-01-25  8:33 ` Wolfram Sang
2023-01-25 22:11   ` Wolfram Sang [this message]
2023-01-26  9:11     ` Bartosz Golaszewski
2023-01-28 19:02       ` Wolfram Sang
2023-01-28 20:16         ` Bartosz Golaszewski
2023-02-06 15:51     ` Uwe Kleine-König
2023-02-06 18:01       ` Bartosz Golaszewski
2023-02-06 18:39         ` Uwe Kleine-König
2023-02-06 15:28 ` Uwe Kleine-König
2023-02-06 15:38   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9GpL9RBNM8H2ZSL@shikoro \
    --to=wsa@kernel.org \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.