From: Simon Horman <simon.horman@corigine.com>
To: Andre Kalb <andre.kalb@sma.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Felix Riemann <felix.riemann@sma.de>
Subject: Re: [PATCH net] net: phy: dp83822: Fix null pointer access on DP83825/DP83826 devices
Date: Thu, 26 Jan 2023 08:21:24 +0100 [thread overview]
Message-ID: <Y9Ip9Ikluruosxb5@corigine.com> (raw)
In-Reply-To: <Y9FzniUhUtbaGKU7@pc6682>
On Wed, Jan 25, 2023 at 07:23:26PM +0100, Andre Kalb wrote:
> From: Andre Kalb <andre.kalb@sma.de>
>
> The probe() function is only used for the DP83822 PHY, leaving the
> private data pointer uninitialized for the smaller DP83825/26 models.
> While all uses of the private data structure are hidden in 82822 specific
> callbacks, configuring the interrupt is shared across all models.
> This causes a NULL pointer dereference on the smaller PHYs as it accesses
> the private data unchecked. Verifying the pointer avoids that.
>
> Fixes: 5dc39fd5ef35 ("net: phy: DP83822: Add ability to advertise Fiber connection")
> Signed-off-by: Andre Kalb <andre.kalb@sma.de>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-01-26 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 18:23 [PATCH net] net: phy: dp83822: Fix null pointer access on DP83825/DP83826 devices Andre Kalb
2023-01-26 7:21 ` Simon Horman [this message]
2023-01-28 8:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9Ip9Ikluruosxb5@corigine.com \
--to=simon.horman@corigine.com \
--cc=andre.kalb@sma.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=felix.riemann@sma.de \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.