From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: stable@vger.kernel.org, Jan Kara <jack@suse.cz>,
Dongliang Mu <mudongliangabcd@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH 4.14/4.19/5.4/5.10/5.15 1/1] fs: reiserfs: remove useless new_opts in reiserfs_remount
Date: Thu, 26 Jan 2023 10:13:23 +0100 [thread overview]
Message-ID: <Y9JEM9toMBcEfDak@kroah.com> (raw)
In-Reply-To: <20230126085846.466209-2-pchelkin@ispras.ru>
On Thu, Jan 26, 2023 at 11:58:46AM +0300, Fedor Pchelkin wrote:
> From: Dongliang Mu <mudongliangabcd@gmail.com>
>
> commit 81dedaf10c20959bdf5624f9783f408df26ba7a4 upstream.
>
> Since the commit c3d98ea08291 ("VFS: Don't use save/replace_mount_options
> if not using generic_show_options") eliminates replace_mount_options
> in reiserfs_remount, but does not handle the allocated new_opts,
> it will cause memory leak in the reiserfs_remount.
>
> Because new_opts is useless in reiserfs_mount, so we fix this bug by
> removing the useless new_opts in reiserfs_remount.
>
> Fixes: c3d98ea08291 ("VFS: Don't use save/replace_mount_options if not using generic_show_options")
> Link: https://lore.kernel.org/r/20211027143445.4156459-1-mudongliangabcd@gmail.com
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
> ---
> fs/reiserfs/super.c | 6 ------
> 1 file changed, 6 deletions(-)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-01-26 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 8:58 [PATCH 4.14/4.19/5.4/5.10/5.15 0/1] fs: reiserfs: remove useless new_opts in reiserfs_remount Fedor Pchelkin
2023-01-26 8:58 ` [PATCH 4.14/4.19/5.4/5.10/5.15 1/1] " Fedor Pchelkin
2023-01-26 9:13 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9JEM9toMBcEfDak@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mudongliangabcd@gmail.com \
--cc=pchelkin@ispras.ru \
--cc=reiserfs-devel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.