From: Leon Romanovsky <leon@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
netdev@vger.kernel.org, sasha.neftin@intel.com,
Naama Meir <naamax.meir@linux.intel.com>
Subject: Re: [PATCH net-next 1/3] igc: Add qbv_config_change_errors counter
Date: Thu, 26 Jan 2023 12:50:32 +0200 [thread overview]
Message-ID: <Y9Ja+EcGcUYMnTFg@unreal> (raw)
In-Reply-To: <20230125212702.4030240-2-anthony.l.nguyen@intel.com>
On Wed, Jan 25, 2023 at 01:27:00PM -0800, Tony Nguyen wrote:
> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
>
> Add ConfigChangeError(qbv_config_change_errors) when user try to set the
> AdminBaseTime to past value while the current GCL is still running.
>
> The ConfigChangeError counter should not be increased when a gate control
> list is scheduled into the future.
>
> User can use "ethtool -S <interface> | grep qbv_config_change_errors"
> command to check the counter values.
>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Tested-by: Naama Meir <naamax.meir@linux.intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc.h | 1 +
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 1 +
> drivers/net/ethernet/intel/igc/igc_main.c | 1 +
> drivers/net/ethernet/intel/igc/igc_tsn.c | 6 ++++++
> 4 files changed, 9 insertions(+)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-01-26 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 21:26 [PATCH net-next 0/3][pull request] Intel Wired LAN Driver Updates 2023-01-25 (igc) Tony Nguyen
2023-01-25 21:27 ` [PATCH net-next 1/3] igc: Add qbv_config_change_errors counter Tony Nguyen
2023-01-26 10:50 ` Leon Romanovsky [this message]
2023-01-25 21:27 ` [PATCH net-next 2/3] igc: offload queue max SDU from tc-taprio Tony Nguyen
2023-01-26 10:51 ` Leon Romanovsky
2023-02-07 13:38 ` Zulkifli, Muhammad Husaini
2023-01-25 21:27 ` [PATCH net-next 3/3] igc: Clean up and optimize watchdog task Tony Nguyen
2023-01-26 10:56 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9Ja+EcGcUYMnTFg@unreal \
--to=leon@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.