From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B963AC54E94 for ; Thu, 26 Jan 2023 17:34:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2C3CA856E5; Thu, 26 Jan 2023 18:34:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="j3ipmP9s"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1FBEC8560A; Thu, 26 Jan 2023 18:34:51 +0100 (CET) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0845B85463 for ; Thu, 26 Jan 2023 18:34:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2a.google.com with SMTP id i12so1986328qvs.2 for ; Thu, 26 Jan 2023 09:34:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Hf0Phwv2Rf61R1GQpMss9NyZB6rkvcs7FpvxXAG8UmI=; b=j3ipmP9sp6uL9BRg8rDZiUh1BtWDgw+QL/C38xxjsruNFKeXK5YHR5FPEJUYSkBfuE B3p7uUZC0FPA2nCH5NA0ergBQrCdyeJayTVHrpUsp06YfwuFfxViOplWItPc/f1hE7ua w5Gokc0uluM82SqHUZBfbaXapJ45V0mhrrFOs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Hf0Phwv2Rf61R1GQpMss9NyZB6rkvcs7FpvxXAG8UmI=; b=L9hGjeZJ1heh7BHm/QyxTTuXQfTRpmcNVkQMn/cG1dyML7IXejTAX0tX8pT332MTin gbTPDD0c74r7xRsXX9LajMEwCpsMTHUdpjEUvTPgZQHifQ47dFoYAFXtGJvcfOxmRf5s /2bDVUm7I4O5u9Kx5li2fyaXleBGVuGW1lFhSzpaOxVAtDcwc7nXbf66Si6i3Ap9tdH2 KQv4KT8U1nauAwlmL/Hy0zYpLuB9vZxrcACfJHsVoxO5p6jh41c6baV76vHZXxprn5tD jDiwG4eX6eBkPbkMDCyRDZA5eXWNqbi4OTMGPt3rm53P1nAONeovtpug11jRhLytr6i1 z35g== X-Gm-Message-State: AO0yUKVmgHllpK1aj6xOumdt/38EQ6lIxJo2NnCaFhLBGiWga2TAjMjn qncbcCfZw1oOqkWp5ln8+bO9iAIo0NhOZ8pfOg4= X-Google-Smtp-Source: AK7set8wXIQRgRSCvTwfPjly1BethvwOxsFzw7UpPH0kk79m8gDcJ+dcsQRk+O6H7xFPBxjA5rxTtw== X-Received: by 2002:a0c:c351:0:b0:531:8f76:3eeb with SMTP id j17-20020a0cc351000000b005318f763eebmr3415788qvi.6.1674754485779; Thu, 26 Jan 2023 09:34:45 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-3a56-04fb-7eea-5810.res6.spectrum.com. [2603:6081:7b00:6400:3a56:4fb:7eea:5810]) by smtp.gmail.com with ESMTPSA id u4-20020a05620a084400b00704c1f4e756sm1286155qku.14.2023.01.26.09.34.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 09:34:45 -0800 (PST) Date: Thu, 26 Jan 2023 12:34:43 -0500 From: Tom Rini To: Troy Kisky Cc: "u-boot@lists.denx.de" , sjg@chromium.org, festevam@gmail.com, marex@denx.de, gary.bisson@lairdconnect.com Subject: Re: CONFIG_IS_ENABLED vs IS_ENABLED Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Xn5bls6q1wcL40qK" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --Xn5bls6q1wcL40qK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 26, 2023 at 09:26:18AM -0800, Troy Kisky wrote: > Thanks Simon >=20 > I switched emails to get rid of the legalese. > Below are scripts to commit the changes sorted by > CONFIG_x variable. The only one I know causes a problem > is CONFIG_OF_LIVE because of >=20 > drivers/core/Makefile > obj-$(CONFIG_$(SPL_)OF_LIVE) >=20 > So, that config needs to keep using CONFIG_IS_ENABLED even > though SPL_OF_LIVE isn't in any Kconfig file. >=20 > Maybe something like > config SPL_OF_LIVE > bool >=20 > can be added to a Kconfig to prevent the bad change. >=20 > git grep CONFIG_IS_ENABLED|sed -n -e > "s/\(CONFIG_IS_ENABLED([0-9a-zA-Z_]*)\)/\n\1\n/gp"| \ > sed -n -r "s/CONFIG_IS_ENABLED\(([0-9a-zA-Z_]+)\)/\1/p" |sort -u|xargs -I > {} \ > sh -c "git grep -E 'config [ST]PL_{}' | grep -q -E -w '[ST]PL_{}' || { git > grep -l 'CONFIG_IS_ENABLED({})' | \ > xargs -IFile sh -c \"sed -i > \\\"s/CONFIG_IS_ENABLED({})/IS_ENABLED(CONFIG_{})/g\\\" File\" ; \ > git commit -a -m\"CONFIG_{}: change CONFIG_IS_ENABLED to IS_ENABLED\"; }" >=20 > git grep -w IS_ENABLED|sed -n -e > "s/\(IS_ENABLED(CONFIG_[0-9a-zA-Z_]*)\)/\n\1\n/gp"| \ > sed -n -r "s/IS_ENABLED\(CONFIG_([0-9a-zA-Z_]+)\)/\1/p" |sort -u|xargs -I > {} \ > sh -c "git grep -E 'config [ST]PL_{}' | grep -q -E -w '[ST]PL_{}' && { g= it > grep -l 'IS_ENABLED(CONFIG_{})' | \ > xargs -IFile sh -c \"sed -i > \\\"s/IS_ENABLED(CONFIG_{})/CONFIG_IS_ENABLED({})/g\\\" File\" ; \ > git commit -a -m\"CONFIG_{}: change IS_ENABLED to CONFIG_IS_ENABLED\"; }" >=20 >=20 > I compile tested a few boards, but a thorough compile test would be good.= I > hope the above helps someone get a few of the changes in mainline. Submitting a PR against https://github.com/u-boot/u-boot/ will trigger an Azure CI run, and so a global build. And adding a test to CI to fail on new introductions of this would be how to prevent further issues. --=20 Tom --Xn5bls6q1wcL40qK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPSua8ACgkQFHw5/5Y0 tyxQaAwAoWUOVGEI2+yrAUhoeOSOYfOKIHoJYx/yCRU1wtvkH4tnQN1gTSr+1H42 qXiPdod+42VzDLpC9mp27R0bsXCi6q7LkeTBHoM5RHEJT4ihQZfOXOYt50yzXoHb E1mUnaVFysK/AkkabYDpWH9E3qE89pwK13R/YRmu7G04orCG4uZFQgLrDsfZF8tJ 1E0NN84h2sGIx99zJKNapBPxMVXgsTmRgyvDzja6dyzIHF7zXC7VSYAT4CcQYcM0 zrNXXPX08Wmm4l00A7Zm74GG52So0/nElYp5qh9n/EftsWF4CCJ0OGO9g3k/0rVc 7J2e/+G6pu77BvH2hODvRmhNzbP+uROb3HF/6EbkQGY+kJsQoTSYt/Nm6kidmeVJ 7wpIy29ikZYzc1rQreyfyV29e0Cb3sUjJdABbUTuJeKaO5c/5ijo+Y+G7+OnhaqI h31zwHL/i8n1laf7+8wqAXtItNKtHjFjhIroR46ndKaxh1n9g1I+STPKMcKRS19V +zBsojlq =wVQN -----END PGP SIGNATURE----- --Xn5bls6q1wcL40qK--