From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E132CC54E94 for ; Thu, 26 Jan 2023 16:40:24 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7F722E75; Thu, 26 Jan 2023 17:39:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7F722E75 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1674751222; bh=4y5T8Z1YzTy28i7M/tIXpNDOtq+YX0jkW9G/xOmLxUs=; h=Date:From:To:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=VHZiKSClMZJXa7qjNgD2lApiXmi+9Glky1dTa2iS/qsbiia6xXZyQMNtDc3fMmfIx Bb191uwouwOYtyy5xbLXBFFe+ndjBhkYPvpJKM+/wE1bujd5ZCitrNe3i7XwozcxS7 kylXRMjmr0ms2CdC6QP8AtMHcLvp9nkJPx2jL46E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0B14BF8025D; Thu, 26 Jan 2023 17:39:32 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4AB26F8027D; Thu, 26 Jan 2023 17:39:30 +0100 (CET) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F34CDF800AE for ; Thu, 26 Jan 2023 17:39:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F34CDF800AE Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=nTJd3UqQ Received: by mail-wr1-x42d.google.com with SMTP id m14so1906288wrg.13 for ; Thu, 26 Jan 2023 08:39:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WcIULWf1hJO2aSG6ip1Q2Tbo7KEX8l8vfq1u07hQEUU=; b=nTJd3UqQHJYIgHfYtrJfyHF3jy6yesQbAxKnBfhlrW7ZZYv5vss1/BwpzGKnU//+pW zpEWqlJSU1UJSI1ZnMW1/fpJO+yHRhfSOrbz1DMeeefUw11iYpnJNzq7lutcwL4sdVQA M8u0eJoyy7W8bYrQw3m8zo2lACqWAzDw3gWKispcuaQug6tcfxcDGjBfRUSmloFUhxGM Sw/XwIM7yxzH/86FHVCW4XrLFoPQQKBIX3LLkuUfneMt47tO5zFJRor1KAkP1FlI503l rgytrxiJuJYtCArZvzsNUT3M8ZVe4MODcWS2KQ1S65g210VjD1EB76AaowZCvsQ/VBqY zIkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WcIULWf1hJO2aSG6ip1Q2Tbo7KEX8l8vfq1u07hQEUU=; b=BbI/iN2t75MuB5y6AmCPAq1Vs9j0yTAAq8dVjMAQQ89wvbWn4VY3OZXdzwYCKMQTnp K8ZBsDqVumSUYXmf4YAIoLhCMnPViXNsivzusUyhn6bx0XxMunMr0Oehg74lWn8Zb2Ed wgYT7WPmQRNuV4Wtj0qY/CnSUzCsGBijNmgrvsa9se2Djni2vFjMDZkYCAjt3r7fUBFg uRqZObied8A2CyeQRJmoBuPCj2g5f74hZweyLMamba7cJ0G/4ntM2f4jZI8cuO34XBrS 9kBYEgmAzCPehnbFTIlC+yVnL/7dc8/9aFTVtk+uGlWL+mI9Z+xmg3QOpp/K5Tm6+iSd 8RiQ== X-Gm-Message-State: AFqh2kr+nzd6EGurPpH0MOAJWL+AonfSrHsjgPeYV9+NkFyj9LYqmi5r qzYZ2ydP4y9Z4svlcRBey0k= X-Google-Smtp-Source: AMrXdXsrjgrGETIMbiJakho1CzIks0SH953VqlAvOj6xcJEoDaMM1z2UyXPlB7L/3oOwE6z5TxzZag== X-Received: by 2002:a05:6000:1f95:b0:2bc:371a:8a2 with SMTP id bw21-20020a0560001f9500b002bc371a08a2mr32915198wrb.37.1674751157968; Thu, 26 Jan 2023 08:39:17 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id l16-20020adffe90000000b002b8fe58d6desm1716079wrr.62.2023.01.26.08.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 08:39:17 -0800 (PST) Date: Thu, 26 Jan 2023 19:39:06 +0300 From: Dan Carpenter To: Takashi Iwai Subject: Re: [PATCH] ALSA: pci: lx6464es: fix a debug loop Message-ID: References: <878rhptq36.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878rhptq36.wl-tiwai@suse.de> X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Takashi Iwai , Maxime Ripard Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Jan 26, 2023 at 01:53:01PM +0100, Takashi Iwai wrote: > On Thu, 26 Jan 2023 10:30:02 +0100, > Dan Carpenter wrote: > > > > This loop accidentally reuses the "i" iterator for both the inside and > > the outside loop. The value of MAX_STREAM_BUFFER is 5. I believe that > > chip->rmh.stat_len is in the 2-12 range. If the value of .stat_len is > > 4 or more then it will loop exactly one time, but if it's less then it > > is a forever loop. > > > > Fixes: 8e6320064c33 ("ALSA: lx_core: Remove useless #if 0 .. #endif") > > Signed-off-by: Dan Carpenter > > --- > > sound/pci/lx6464es/lx_core.c | 12 +++++------- > > 1 file changed, 5 insertions(+), 7 deletions(-) > > > > diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c > > index d3f58a3d17fb..7c1b380a54c0 100644 > > --- a/sound/pci/lx6464es/lx_core.c > > +++ b/sound/pci/lx6464es/lx_core.c > > @@ -493,13 +493,11 @@ int lx_buffer_ask(struct lx6464es *chip, u32 pipe, int is_capture, > > dev_dbg(chip->card->dev, > > "CMD_08_ASK_BUFFERS: needed %d, freed %d\n", > > *r_needed, *r_freed); > > - for (i = 0; i < MAX_STREAM_BUFFER; ++i) { > > - for (i = 0; i != chip->rmh.stat_len; ++i) > > - dev_dbg(chip->card->dev, > > - " stat[%d]: %x, %x\n", i, > > - chip->rmh.stat[i], > > - chip->rmh.stat[i] & MASK_DATA_SIZE); > > - } > > + for (i = 0; i < chip->rmh.stat_len; ++i) > > Judging from the previous lines, the access over MAX_STREAM_BUFFER > might be unsafe. So I guess a more safer change would be something > like: > > for (i = 0; i < MAX_STREAM_BUFFER && chip->rmh.stat_len; ++i) && i < chip->rmh.stat_len TBH, I'd prefer to just delete all this code since it used be ifdef 0. But I'll resend as you have suggested. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E626CC05027 for ; Thu, 26 Jan 2023 16:39:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231944AbjAZQjX (ORCPT ); Thu, 26 Jan 2023 11:39:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231852AbjAZQjW (ORCPT ); Thu, 26 Jan 2023 11:39:22 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F7934A202 for ; Thu, 26 Jan 2023 08:39:19 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id t18so2390049wro.1 for ; Thu, 26 Jan 2023 08:39:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WcIULWf1hJO2aSG6ip1Q2Tbo7KEX8l8vfq1u07hQEUU=; b=nTJd3UqQHJYIgHfYtrJfyHF3jy6yesQbAxKnBfhlrW7ZZYv5vss1/BwpzGKnU//+pW zpEWqlJSU1UJSI1ZnMW1/fpJO+yHRhfSOrbz1DMeeefUw11iYpnJNzq7lutcwL4sdVQA M8u0eJoyy7W8bYrQw3m8zo2lACqWAzDw3gWKispcuaQug6tcfxcDGjBfRUSmloFUhxGM Sw/XwIM7yxzH/86FHVCW4XrLFoPQQKBIX3LLkuUfneMt47tO5zFJRor1KAkP1FlI503l rgytrxiJuJYtCArZvzsNUT3M8ZVe4MODcWS2KQ1S65g210VjD1EB76AaowZCvsQ/VBqY zIkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WcIULWf1hJO2aSG6ip1Q2Tbo7KEX8l8vfq1u07hQEUU=; b=rq+wq5Wjz1N9ZI5O8gDSqp22Ig7hVDCt946HNwMIj+ku3UT32R95y4Bm/QL3kznola e+8yDUyN8zF+2rW0KbcAhVnllAc1Fq5yKd/LapvRmvtsEmU6je7bQ2lYoVvUe5FFViMX /RhZ3BNWa+KUF+puHRbG+Xv5wGLUrSy6c7jy0yP8MD96eezDlRnLVCRVhlMdG9lV2otS u1u5afLl6QqAcM1iteZx5+0Ql8bKW9CR69vaC49q06NE2PWsx8AemkDEJzFXsuc5KXG/ 0LQIk7UzhUwceSvNLgIs72OaCNL9UWojlNr79IEV+RiqaYEEfh3gIqSCvbnXy8+F3Cu4 uSBQ== X-Gm-Message-State: AFqh2krG+wz3FHQID5Pv2HLJu7QBHJgm5+0EEMO6EnAkBIUpQTJsNTkT 183QiflKDLYaw9UT32+seNg= X-Google-Smtp-Source: AMrXdXsrjgrGETIMbiJakho1CzIks0SH953VqlAvOj6xcJEoDaMM1z2UyXPlB7L/3oOwE6z5TxzZag== X-Received: by 2002:a05:6000:1f95:b0:2bc:371a:8a2 with SMTP id bw21-20020a0560001f9500b002bc371a08a2mr32915198wrb.37.1674751157968; Thu, 26 Jan 2023 08:39:17 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id l16-20020adffe90000000b002b8fe58d6desm1716079wrr.62.2023.01.26.08.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 08:39:17 -0800 (PST) Date: Thu, 26 Jan 2023 19:39:06 +0300 From: Dan Carpenter To: Takashi Iwai Cc: Jaroslav Kysela , Maxime Ripard , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: pci: lx6464es: fix a debug loop Message-ID: References: <878rhptq36.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878rhptq36.wl-tiwai@suse.de> Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Thu, Jan 26, 2023 at 01:53:01PM +0100, Takashi Iwai wrote: > On Thu, 26 Jan 2023 10:30:02 +0100, > Dan Carpenter wrote: > > > > This loop accidentally reuses the "i" iterator for both the inside and > > the outside loop. The value of MAX_STREAM_BUFFER is 5. I believe that > > chip->rmh.stat_len is in the 2-12 range. If the value of .stat_len is > > 4 or more then it will loop exactly one time, but if it's less then it > > is a forever loop. > > > > Fixes: 8e6320064c33 ("ALSA: lx_core: Remove useless #if 0 .. #endif") > > Signed-off-by: Dan Carpenter > > --- > > sound/pci/lx6464es/lx_core.c | 12 +++++------- > > 1 file changed, 5 insertions(+), 7 deletions(-) > > > > diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c > > index d3f58a3d17fb..7c1b380a54c0 100644 > > --- a/sound/pci/lx6464es/lx_core.c > > +++ b/sound/pci/lx6464es/lx_core.c > > @@ -493,13 +493,11 @@ int lx_buffer_ask(struct lx6464es *chip, u32 pipe, int is_capture, > > dev_dbg(chip->card->dev, > > "CMD_08_ASK_BUFFERS: needed %d, freed %d\n", > > *r_needed, *r_freed); > > - for (i = 0; i < MAX_STREAM_BUFFER; ++i) { > > - for (i = 0; i != chip->rmh.stat_len; ++i) > > - dev_dbg(chip->card->dev, > > - " stat[%d]: %x, %x\n", i, > > - chip->rmh.stat[i], > > - chip->rmh.stat[i] & MASK_DATA_SIZE); > > - } > > + for (i = 0; i < chip->rmh.stat_len; ++i) > > Judging from the previous lines, the access over MAX_STREAM_BUFFER > might be unsafe. So I guess a more safer change would be something > like: > > for (i = 0; i < MAX_STREAM_BUFFER && chip->rmh.stat_len; ++i) && i < chip->rmh.stat_len TBH, I'd prefer to just delete all this code since it used be ifdef 0. But I'll resend as you have suggested. regards, dan carpenter