From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECD9217E for ; Sat, 28 Jan 2023 00:14:40 +0000 (UTC) Date: Sat, 28 Jan 2023 00:14:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1674864878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AGaeFUGsY+6rt83U5mh2TKehFjF1vFRLmfOY7UCFQ/I=; b=pNhbow7uuLKcjf8GjIlH4ZXZVFW+eGn1TQv6s84utXqrl5IMaqY0MLjFWh+RPOCyb8ix/m t/xU3YchLxx9v6anaCF0TsOqK3YFH9+e1fUV3Gao6b4JXfJrZqFPEpWdet4D0vLvfsmi3l JZoapCY84ZSz8/qDRs6AmgJQp0ei5c4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Gavin Shan Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, pbonzini@redhat.com, corbet@lwn.net, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, yuzhe@nfschina.com, seanjc@google.com, isaku.yamahata@intel.com, ricarkol@google.com, eric.auger@redhat.com, renzhengeek@gmail.com, reijiw@google.com, shan.gavin@gmail.com Subject: Re: [PATCH v4 1/4] KVM: arm64: Include kvm_mmu.h from vgic.h Message-ID: References: <20230127235150.17025-1-gshan@redhat.com> <20230127235150.17025-2-gshan@redhat.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230127235150.17025-2-gshan@redhat.com> X-Migadu-Flow: FLOW_OUT On Sat, Jan 28, 2023 at 07:51:47AM +0800, Gavin Shan wrote: > We need a unified helper in 'kvm/vgic/vgic.h' to write guest memory. In > the helper, the check of no-running-vcpu context for dirty ring will be > applied. kvm_write_guest_lock(), defined in 'include/asm/kvm_mmu.h', is > going to be dereferenced by the unified helper. > > Include 'include/asm/kvm_mmu.h' to 'kvm/vgic/vgic.h' to avoid including > the former header file when the later one is needed. With the change, > the duplicate inclusions of 'include/asm/kvm_mmu.h' are removed. > > No functional change intended. > > Suggested-by: Oliver Upton No, I did not suggest for you to do this. I had suggested you just include asm/kvm_mmu.h from the vgic header, not to go and remove it from all the files that include vgic.h. Who cares if kvm_mmu.h gets included twice? Include guards exist for this exact reason. -- Thanks, Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 387C8C54EAA for ; Sat, 28 Jan 2023 00:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f0jhveU5atfPuh4a79/IWC0/JCa0ynE91Xt97+y3mcA=; b=QlGhVQHxfWdnW9 GdC8CeRJRglSOF9VeyK51c66KWTV9IhR4k8LtD9oevgoP2DpZkOIlL/YezLmV4z0FKj1UzD6slmop ZPu0WkMmq3SViLy6aHHgOV3Ax+Sg53SL3jsZ3ciNEAEpyftIEBsa09qtbiY8/gHTLc4eqioYIov7k sIfHZqSJG4aEFu7koQIqFOkX59+H4JbK/R4/Qnq48WziMX9w2HYLFECYAaEP1mo7d/lqX36XI1E90 DPCFEV1MrgzZoKStXJzz0qyl8G/4eaSjY+W1TYHsq1qcj7vqsDgkPspsbeRf3upIKILC8zogAP+a5 sm1QrKLUAuAVrV9NWfGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLYrq-00Gw1t-I7; Sat, 28 Jan 2023 00:14:50 +0000 Received: from out2.migadu.com ([188.165.223.204]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLYrm-00Gw10-MU for linux-arm-kernel@lists.infradead.org; Sat, 28 Jan 2023 00:14:48 +0000 Date: Sat, 28 Jan 2023 00:14:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1674864878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AGaeFUGsY+6rt83U5mh2TKehFjF1vFRLmfOY7UCFQ/I=; b=pNhbow7uuLKcjf8GjIlH4ZXZVFW+eGn1TQv6s84utXqrl5IMaqY0MLjFWh+RPOCyb8ix/m t/xU3YchLxx9v6anaCF0TsOqK3YFH9+e1fUV3Gao6b4JXfJrZqFPEpWdet4D0vLvfsmi3l JZoapCY84ZSz8/qDRs6AmgJQp0ei5c4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Gavin Shan Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, pbonzini@redhat.com, corbet@lwn.net, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, yuzhe@nfschina.com, seanjc@google.com, isaku.yamahata@intel.com, ricarkol@google.com, eric.auger@redhat.com, renzhengeek@gmail.com, reijiw@google.com, shan.gavin@gmail.com Subject: Re: [PATCH v4 1/4] KVM: arm64: Include kvm_mmu.h from vgic.h Message-ID: References: <20230127235150.17025-1-gshan@redhat.com> <20230127235150.17025-2-gshan@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230127235150.17025-2-gshan@redhat.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_161447_337781_71CF2535 X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jan 28, 2023 at 07:51:47AM +0800, Gavin Shan wrote: > We need a unified helper in 'kvm/vgic/vgic.h' to write guest memory. In > the helper, the check of no-running-vcpu context for dirty ring will be > applied. kvm_write_guest_lock(), defined in 'include/asm/kvm_mmu.h', is > going to be dereferenced by the unified helper. > > Include 'include/asm/kvm_mmu.h' to 'kvm/vgic/vgic.h' to avoid including > the former header file when the later one is needed. With the change, > the duplicate inclusions of 'include/asm/kvm_mmu.h' are removed. > > No functional change intended. > > Suggested-by: Oliver Upton No, I did not suggest for you to do this. I had suggested you just include asm/kvm_mmu.h from the vgic header, not to go and remove it from all the files that include vgic.h. Who cares if kvm_mmu.h gets included twice? Include guards exist for this exact reason. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel