From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C62DBC38142 for ; Sat, 28 Jan 2023 00:56:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233544AbjA1A4t (ORCPT ); Fri, 27 Jan 2023 19:56:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232038AbjA1A4r (ORCPT ); Fri, 27 Jan 2023 19:56:47 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 895137E6B0 for ; Fri, 27 Jan 2023 16:56:46 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id j5so6184935pjn.5 for ; Fri, 27 Jan 2023 16:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rI2c99rcSfo6XNONmsHvFbfDglWETie8DloTdHfivvk=; b=p8go5RAKjk+0e+oaFqXN0FR2I7+FTTYJEnAPgt6hFL+lY0R6cp2EFioBSzJF+6Lu0u oUmHkfzMFGfYHb+CpRX3ITsRXEPmTifnvf73ftA6CRqy9RJMCVNLaKmj7OSYR47H2MXB 2ulmKjdrS8wRLf586AD0fqBtxIbNfEkpnHFvJBvsaYPsozlf7BHD97Ifh6JW6SWeKOQI Nkbv+n5vwSF8JAhQHLBeeREs2Y/o2lfnR1hwx69SYzwXZ1ilM6n26IUGpqilwe7piEXt QvEoPOWtUxcVT4TrDDchhiAK8mqwNk5ToSEpZJltF3+Hm5pDLTHGomtbwjrMs6u+ssrg Uw3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rI2c99rcSfo6XNONmsHvFbfDglWETie8DloTdHfivvk=; b=1cn0j03Wf2z4ershDvpQBekpYoKjGJlN0ldwNSnIpcRwzi1gbGH3lBpIezcTiOIYlC il/FVzNE4GeuVR8JaaL283b8GEDEBWdFimAfG7HoPgyP9rPCFU80Xx2zc5Qi9OLUmAQV 1x3CjuJlezr7wFb6AkBguowH3mMUrGcGIFo2SBJgfuqkRit98QAhjEVSk0ZOl68NeoAh iijcy3JdjsxDs28Bs19Trg3UAvM49nLTBLZroRrupLnivlbbwdM8IjojCJuWaUDcwNcw 16Jh1HUub7SOC3sE86B9AGZUTsH6yQK1YowPaJkt7wVMhdf95VPrVSo7kl794ndZ/xxQ iRJw== X-Gm-Message-State: AO0yUKW9HFbvzCac5iYj+h9UMvCF6ByhCI3eFMDkivBvzbYUm5cknr0L D0bGhx6fD5MkdVc3EaBk2dOcJw== X-Google-Smtp-Source: AK7set8krNpzRJzicYHFKi93jEMrwpbzoRjimX3jZk+2Qog5M44S0ZJLGQeBdajigna7YUvZLYX77A== X-Received: by 2002:a05:6a20:6d15:b0:a4:efde:2ed8 with SMTP id fv21-20020a056a206d1500b000a4efde2ed8mr263956pzb.0.1674867405931; Fri, 27 Jan 2023 16:56:45 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id c9-20020a6566c9000000b0046ff3634a78sm2908265pgw.71.2023.01.27.16.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 16:56:45 -0800 (PST) Date: Sat, 28 Jan 2023 00:56:42 +0000 From: Sean Christopherson To: Maxim Levitsky Cc: kvm@vger.kernel.org, Sandipan Das , Paolo Bonzini , Jim Mattson , Peter Zijlstra , Dave Hansen , Borislav Petkov , Pawan Gupta , Thomas Gleixner , Ingo Molnar , Josh Poimboeuf , Daniel Sneddon , Jiaxi Chen , Babu Moger , linux-kernel@vger.kernel.org, Jing Liu , Wyes Karny , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v2 04/11] KVM: SVM: drop the SVM specific H_FLAGS Message-ID: References: <20221129193717.513824-1-mlevitsk@redhat.com> <20221129193717.513824-5-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221129193717.513824-5-mlevitsk@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Nov 29, 2022, Maxim Levitsky wrote: > @@ -3580,7 +3583,7 @@ bool svm_nmi_blocked(struct kvm_vcpu *vcpu) > return false; > > ret = (vmcb->control.int_state & SVM_INTERRUPT_SHADOW_MASK) || > - (vcpu->arch.hflags & HF_NMI_MASK); > + (svm->nmi_masked); Unnecessary parantheses. > > return ret; > }