From: Simon Horman <simon.horman@corigine.com>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: tulip: Fix a typo ("defualt")
Date: Sun, 29 Jan 2023 19:35:15 +0100 [thread overview]
Message-ID: <Y9a8Y7BZ7wIIZFbm@corigine.com> (raw)
In-Reply-To: <20230129154005.1567160-1-j.neuschaefer@gmx.net>
On Sun, Jan 29, 2023 at 04:40:05PM +0100, Jonathan Neuschäfer wrote:
> Spell it as "default".
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Looks good :)
There also seems to be a misspelling of heartbeat (as hearbeat) on line 277.
Perhaps it would be good to fix that at the same time?
> ---
> drivers/net/ethernet/dec/tulip/tulip.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/tulip.h b/drivers/net/ethernet/dec/tulip/tulip.h
> index 0ed598dc7569c..0aed3a1d8fe4b 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip.h
> +++ b/drivers/net/ethernet/dec/tulip/tulip.h
> @@ -250,7 +250,7 @@ enum t21143_csr6_bits {
> csr6_ttm = (1<<22), /* Transmit Threshold Mode, set for 10baseT, 0 for 100BaseTX */
> csr6_sf = (1<<21), /* Store and forward. If set ignores TR bits */
> csr6_hbd = (1<<19), /* Heart beat disable. Disables SQE function in 10baseT */
> - csr6_ps = (1<<18), /* Port Select. 0 (defualt) = 10baseT, 1 = 100baseTX: can't be set */
> + csr6_ps = (1<<18), /* Port Select. 0 (default) = 10baseT, 1 = 100baseTX: can't be set */
> csr6_ca = (1<<17), /* Collision Offset Enable. If set uses special algorithm in low collision situations */
> csr6_trh = (1<<15), /* Transmit Threshold high bit */
> csr6_trl = (1<<14), /* Transmit Threshold low bit */
> --
> 2.39.0
>
next prev parent reply other threads:[~2023-01-29 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 15:40 [PATCH] net: tulip: Fix a typo ("defualt") Jonathan Neuschäfer
2023-01-29 18:35 ` Simon Horman [this message]
2023-01-29 19:47 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9a8Y7BZ7wIIZFbm@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.neuschaefer@gmx.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.