From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: ye.xingchen@zte.com.cn
Cc: dmitry.torokhov@gmail.com, jonathan.cameron@huawei.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource()
Date: Mon, 30 Jan 2023 14:19:38 +0200 [thread overview]
Message-ID: <Y9e12m28aOMlTs0c@smile.fi.intel.com> (raw)
In-Reply-To: <202301281611305841413@zte.com.cn>
On Sat, Jan 28, 2023 at 04:11:30PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
...
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - keypad_data->base = devm_ioremap_resource(&pdev->dev, res);
> + keypad_data->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
Why?
What we need here is simple devm_platform_ioremap_resource().
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-01-30 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 8:11 [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-01-30 4:48 ` Dmitry Torokhov
2023-01-30 12:19 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9e12m28aOMlTs0c@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.