From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B653C54EED for ; Mon, 30 Jan 2023 16:48:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234038AbjA3QsQ (ORCPT ); Mon, 30 Jan 2023 11:48:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjA3QsP (ORCPT ); Mon, 30 Jan 2023 11:48:15 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 005C514E8E; Mon, 30 Jan 2023 08:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iSppJpmbh5yY9f1++jDLbK6EHrj4YtdTjVgqiD7xZtE=; b=t143gCujAMScBKZumahGmYIUKE 114PPBcgvsfprD7++/4HiAGm2f5MmIwhvQtm7RERN5nPjqZLRBTM90n3Zi2GY+iLiDMfHdYF7TyPe 79RQjd+C2bS2B3fYBvpM6fMEn/R0UzuDPgqa83Pfn5nWUHmJr7EJ74RR/08NkmtFY/0zovKiWfotM 5QYrH6huVb2H+AltAwCBc/akCxpdER69TrIdkVUfhewCLawK4Z+U80TeY7bdxon9YEqmLNGij+0o6 pYrNRhFvqvw1B8EncYI9jKlveG0FjAVNPtlEhaH5wBK8MeelowRmpYHCQr8nqJ4NCWSPLF61VtEnS zJjznd3A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36362) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pMXK9-0003Vy-Fz; Mon, 30 Jan 2023 16:48:05 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pMXK6-0003HB-KP; Mon, 30 Jan 2023 16:48:02 +0000 Date: Mon, 30 Jan 2023 16:48:02 +0000 From: "Russell King (Oracle)" To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Yoshihiro Shimoda , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH net-next v4 4/4] net: ethernet: renesas: rswitch: Add phy_power_{on,off}() calling Message-ID: References: <20230127142621.1761278-1-yoshihiro.shimoda.uh@renesas.com> <20230127142621.1761278-5-yoshihiro.shimoda.uh@renesas.com> <20230130173048.520f3f3e@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230130173048.520f3f3e@thinkpad> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Mon, Jan 30, 2023 at 05:30:48PM +0100, Marek Behún wrote: > But rswitch already uses phylink, so should Yoshihiro convert it whole > back to phylib? (I am not sure how much phylink API is used, maybe it > can stay that way and the new phylib function as proposed in Yoshihiro's > previous proposal can just be added.) In terms of "how much phylink API is used"... well, all the phylink ops functions are currently entirely empty. So, phylink in this case is just being nothing more than a shim between the driver and the corresponding phylib functions. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!