From: Chen Yu <yu.c.chen@intel.com>
To: Zhang Qiao <zhangqiao22@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, Roman Kagan <rkagan@amazon.de>,
"Daniel Bristot de Oliveira" <bristot@redhat.com>,
Ben Segall <bsegall@google.com>, Ingo Molnar <mingo@redhat.com>,
Waiman Long <longman@redhat.com>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Valentin Schneider <vschneid@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
"Mel Gorman" <mgorman@suse.de>,
Juri Lelli <juri.lelli@redhat.com>
Subject: Re: [PATCH] sched/fair: sanitize vruntime of entity being placed
Date: Mon, 30 Jan 2023 21:15:37 +0800 [thread overview]
Message-ID: <Y9fC+W8eah73WWP8@chenyu5-mobl1> (raw)
In-Reply-To: <8a2e400f-868c-1d98-3c9b-de2e0d41f55c@huawei.com>
On 2023-01-29 at 09:27:07 +0800, Zhang Qiao wrote:
> Hi, Chenyu,
>
> On 2023/1/29 1:27, Chen Yu wrote:
> > Hi Roman, Qiao,
> > On 2023-01-27 at 17:32:30 +0100, Roman Kagan wrote:
> >> From: Zhang Qiao <zhangqiao22@huawei.com>
[snip]
> > If I understand correctly, se->exec_start is just updated by enqueue_entity()->update_curr(cfs_rq),
>
> When a task go to sleep, se->exec_start will update at dequeue_entity()->update_curr(cfs_rq).
> And enqueue_entity()->update_curr(cfs_rq) just update current se.
>
You are right. update_curr(cfs_rq) only updates the current running one and the se
has not been queued yet.
thanks,
Chenyu
prev parent reply other threads:[~2023-01-30 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 16:32 [PATCH] sched/fair: sanitize vruntime of entity being placed Roman Kagan
2023-01-28 6:42 ` kernel test robot
2023-01-28 7:45 ` kernel test robot
2023-01-28 10:41 ` Zhang Qiao
2023-01-28 17:27 ` Chen Yu
2023-01-29 1:27 ` Zhang Qiao
2023-01-30 13:15 ` Chen Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9fC+W8eah73WWP8@chenyu5-mobl1 \
--to=yu.c.chen@intel.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rkagan@amazon.de \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zhangqiao22@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.