From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C3ADC54EAA for ; Mon, 30 Jan 2023 14:54:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237886AbjA3Oy6 (ORCPT ); Mon, 30 Jan 2023 09:54:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237882AbjA3Oy5 (ORCPT ); Mon, 30 Jan 2023 09:54:57 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA25C2942E for ; Mon, 30 Jan 2023 06:54:55 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id o18so1847668wrj.3 for ; Mon, 30 Jan 2023 06:54:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=DBOpQJYrFBTRisXeKisTfMrcTyjxLh2di8KfVPbWNqU=; b=yKHFfxGFUyCjIMcxvHJEvAUDSj9OgEptKjOD4txVEqyNPntE8lDUViVchodbt0Hj1k c9FHCupazK3N7mGho43gKincjUaeyT7uCaNAy/6uOEg8XZxxztCvFK7oTBh2cJ4gmLgE 7r+5gKQ7fPfY3b+YJ8LnW/fwL0vA7ZiaIvLYtuOwEue7lNs7ZVJXg8eZIT8qFLdc8zvt kaMj/LcWL6RJdqqLRdgOT7I+67H8NdS2dsMECQStAZAddAVkeXByo+gddLNkh9BOuc3R 1CexiZK4c6kCRryEirmAuBMG8PTviOWRK0QWC5qWNALfDzShp++ifTbl7sJXONrQamjH VxGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DBOpQJYrFBTRisXeKisTfMrcTyjxLh2di8KfVPbWNqU=; b=MvxyZdiOM0n5dbAJcb1eb4iRGVm59VNx9Flsywn92jkHAEcHCgxQYHhw1gL7mJVFsA MofJdGJiz/Nriz+b91f0pLa2a0ecsoYWRL1MBCZJ4A4oSC1MRHSc9DX3A/xvUPG1yLeO 25dEogHcNgHVR6EM1k4xuiXfYbrolDPeeGGXR/hc1lhdt4/5KctiLhIlyg+/oOPD8JfP DCWD+pcDLH/usqwT2H6h57J4dtIiDqmazIrBDIyzO1SutpAT7AeMKFjg5qcdxgne9GX6 V7nyWhUnL35OVQNfW0sDP9aYD8kENxLHabgA2OS0UCzOwYs/oXHK5ZbXMbZPGgbEmMcD UFUQ== X-Gm-Message-State: AO0yUKXUaPyb//RKT2gelSVr0FywFs9mE9FS3aWC0Yafn/hVLIuQbQ+C L0DcF6DCnmseWXcU52jaQm0CIA== X-Google-Smtp-Source: AK7set984+SMpkQTbwcvMG4YeVGE0ndrZoyiRnap/3z+W0qvqktcQHTobeelX/749h7V8DxCcL4QEg== X-Received: by 2002:a5d:4c49:0:b0:2bf:c82d:7ad4 with SMTP id n9-20020a5d4c49000000b002bfc82d7ad4mr13257293wrt.7.1675090494310; Mon, 30 Jan 2023 06:54:54 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id m13-20020a5d56cd000000b002bfd462d13asm11233373wrw.18.2023.01.30.06.54.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 06:54:52 -0800 (PST) Date: Mon, 30 Jan 2023 16:54:51 +0200 From: Abel Vesa To: Oleksij Rempel Cc: Richard Cochran , devicetree@vger.kernel.org, kernel@pengutronix.de, Stephen Boyd , Fabio Estevam , Sascha Hauer , linux-clk@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Krzysztof Kozlowski , netdev@vger.kernel.org, Shawn Guo , Michael Turquette , Abel Vesa Subject: Re: [PATCH v2 15/19] clk: imx6ul: fix enet1 gate configuration Message-ID: References: <20230117061453.3723649-1-o.rempel@pengutronix.de> <20230117061453.3723649-16-o.rempel@pengutronix.de> <20230130121530.GA10978@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230130121530.GA10978@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 23-01-30 13:15:30, Oleksij Rempel wrote: > On Sun, Jan 29, 2023 at 07:32:31PM +0200, Abel Vesa wrote: > > On 23-01-17 07:14:49, Oleksij Rempel wrote: > > > According to the "i.MX 6UltraLite Applications Processor Reference Manual, > > > Rev. 2, 03/2017", BIT(13) is ENET1_125M_EN which is not controlling root > > > of PLL6. It is controlling ENET1 separately. > > > > > > So, instead of this picture (implementation before this patch): > > > fec1 <- enet_ref (divider) <---------------------------, > > > |- pll6_enet (gate) > > > fec2 <- enet2_ref_125m (gate) <- enet2_ref (divider) <-´ > > > > > > we should have this one (after this patch): > > > fec1 <- enet1_ref_125m (gate) <- enet1_ref (divider) <-, > > > |- pll6_enet > > > fec2 <- enet2_ref_125m (gate) <- enet2_ref (divider) <-´ > > > > > > With this fix, the RMII reference clock will be turned off, after > > > setting network interface down on each separate interface > > > (ip l s dev eth0 down). Which was not working before, on system with both > > > FECs enabled. > > > > > > Signed-off-by: Oleksij Rempel > > > > I'm OK with this. Maybe a fixes tag ? > > Hm. Initial commit was: > Fixes: 787b4271a6a0 ("clk: imx: add imx6ul clk tree support") > but this patch will not apply on top of it. > Next possible commit would be: > Fixes: 1487b60dc2d2 ("clk: imx6ul: Switch to clk_hw based API") > But this patch didn't introduce this issue, it was just refactoring. Hm, in that case I don't think is qoing to be backported ever. > > What do you prefer? I'll apply it as it is. Thanks. > > Regards, > Oleksij > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |