From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85CB7C636CD for ; Mon, 30 Jan 2023 21:21:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A3CDF857F6; Mon, 30 Jan 2023 22:21:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="mfvqxk33"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 97DA985810; Mon, 30 Jan 2023 22:21:32 +0100 (CET) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1610485194 for ; Mon, 30 Jan 2023 22:21:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id u18so7084094qvv.9 for ; Mon, 30 Jan 2023 13:21:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xDMfy7ryj4dgSbHYhSwUOPABZFwaoh7m/JH2QeK7ZW4=; b=mfvqxk33xscC1LK+MBDLu2htFQci828jMDH31xbtgxErjdY1+q7uUuNYfioiHxKwkl b1QXX1soSLZMyqFVzVKEAV+I/2Wx8sNcYWgxXmAKyVXy4YFDvMf8vUhM2Rgwllozwv4P VH5OEqaBnq+AREV4CJq2ZJqKk4vtkbICR9UXk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xDMfy7ryj4dgSbHYhSwUOPABZFwaoh7m/JH2QeK7ZW4=; b=lrfC8TbyluyQQSnFNUjNFfjH4vXgPZtH7x4YSD+2QlzScxrRDupdfCwNgwqzSeG/M6 NDtQqH5FRER7NHVbrR+F1dPfn1zqYkS18mTf7E/ZRJ/5oEqkFzdcsilqaLCmJSLFMRfa j86h8bJ7OCnK0b1URsXTfMlFtqYh+WwzYpuz9027jdq1JComeWZcyhK0NGn8mBfL1Wft 8gtp/62Ev7hrnbXy0uCXKY3ha1+5njU4XgFSFYWQ4Uti+gUvttL1ynngkX6f7L343dx0 sQcZX0eCanb8ZZZ6zXspNFBX46VjZ9SPuXt9+JjMOUW2Y6zDJRnZg+GjT9mN4i31eRzA 5D8A== X-Gm-Message-State: AO0yUKXNAmGrqYTu+P8wy0SSyUs1zZHvmYiS5vudu/G0QDpB37JTb9hu JT6Ft8pOPg9moG/YaWFI+MPQLw== X-Google-Smtp-Source: AK7set9TIHBFNz0Cewnc6By7u6egiE6scJDOa5RYIsASsg24L7X89m3yOOILsEoUf7CDwj6XSWBZgw== X-Received: by 2002:a0c:f414:0:b0:537:77c3:5cfd with SMTP id h20-20020a0cf414000000b0053777c35cfdmr33116330qvl.18.1675113688857; Mon, 30 Jan 2023 13:21:28 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-31da-0362-f50e-b4ac.res6.spectrum.com. [2603:6081:7b00:6400:31da:362:f50e:b4ac]) by smtp.gmail.com with ESMTPSA id x124-20020a379582000000b006cbc00db595sm8742370qkd.23.2023.01.30.13.21.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 13:21:28 -0800 (PST) Date: Mon, 30 Jan 2023 16:21:26 -0500 From: Tom Rini To: Jagan Teki Cc: Kever Yang , Simon Glass , Philipp Tomsich , u-boot@lists.denx.de, Quentin Schulz , Anand Moon Subject: Re: [PATCH] Revert "rockchip: Only call binman when TPL available" Message-ID: References: <20230127072133.852818-1-jagan@edgeble.ai> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PxiheB8GyMwO1wHR" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --PxiheB8GyMwO1wHR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 31, 2023 at 02:44:52AM +0530, Jagan Teki wrote: > On Mon, 30 Jan 2023 at 20:45, Tom Rini wrote: > > > > On Mon, Jan 30, 2023 at 08:29:35PM +0530, Jagan Teki wrote: > > > On Fri, 27 Jan 2023 at 12:51, Jagan Teki wrote: > > > > > > > > This reverts commit f5315dd6290a588434e4f79bfd2886bb7df9210d. > > > > > > > > [why] > > > > TPL is not mandatory for not all Rockchip SoCs, some SoCs like > > > > RK356x, and RK3588 still use mainline u-boot without TPL as > > > > their ddr init programs are accessed via binaries provided by > > > > Rockchip instead of ddr source code. > > > > > > > > Marking TPL build makes it not able to build u-boot.itb on > > > > RK356x targets so revert this so that it can build an SPL build > > > > that would support all across Rockchip platforms. > > > > > > > > Suggested-by: Quentin Schulz > > > > Signed-off-by: Jagan Teki > > > > --- > > > > > > Can someone apply this before -rc is released? > > > > Yes, but where's the follow-up series to make both cases work again, I > > think I missed it? >=20 > No follow-up series from my side, I think this revert will compatible > with all rockchip platforms. Well, I assumed there was some subset that needed this change or Kever wouldn't have posted and merged his change so close to the release. And I do think we need something with CONFIG_BUILD_TARGET so that this problem would have been caught in CI, in the future. --=20 Tom --PxiheB8GyMwO1wHR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPYNNYACgkQFHw5/5Y0 tyw/cgv/crV86LBQrrcaj+ud3XD6Ph7oufcV8GxqcgcvDqZAkj9fBsDxu10292Cm 7TNKVDzWjI+mFdt/cMwhesEKH+4+hEgJo6mnVD6KkLu6wFppN9EP/FKdJchant/K 7VNf4lUggdihiVOpLMBCo5bTxIcABEwZw/VWvXbZYUdRAob235L3UcghE8UhyOx9 c5TXgOvzBXcFoyrfzLVbIHddkPPHyFbd4QtApuYrJKo8M9XBDY7sxYA+HZoODbXB sqoPgI4iSe74OCUyseAOUKlB5EzSlxYbNt1WH92wv7orBZpbOdLDYXOw4K9wwjVc A7Y2ki9ApBnD6EFyiIdZ+Z2QgtrB7S7mEkDFgNPJuHbkfSb+OsfIiVPRwRANCn1M QyJHwUZ10L+G7KB3b5YXwj3z1JpsB0gffptQLNm+pb6wYp6sF/fJXG9C5PFYJHwX DujFHLko/g4/dBX0RFu0yPviw9eYw0Fb15W0dUJPwxOu6oEeFINJ05/GFWDuVTXT hCGKXuLR =JTp5 -----END PGP SIGNATURE----- --PxiheB8GyMwO1wHR--