All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	ming.lei@redhat.com
Subject: Re: [PATCH] block: Revert "let blkcg_gq grab request queue's refcnt"
Date: Tue, 31 Jan 2023 09:52:24 +0800	[thread overview]
Message-ID: <Y9h0WMOqNau4s0c0@T590> (raw)
In-Reply-To: <20230130232257.972224-1-bvanassche@acm.org>

Hi Bart,

On Mon, Jan 30, 2023 at 03:22:57PM -0800, Bart Van Assche wrote:
> Since commit 0a9a25ca7843 ("block: let blkcg_gq grab request queue's
> refcnt") for many request queues the reference count drops to 1 when
> the request queue is destroyed instead of to 0. In other words, the
> request queue is leaked. Fix this by reverting that commit.

When/where you observe that the reference count drops to 1 instead of 0?

Do you have kmem leak log?

Probably, the last drop is in blkg_free_workfn().


Thanks, 
Ming


  reply	other threads:[~2023-01-31  1:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30 23:22 [PATCH] block: Revert "let blkcg_gq grab request queue's refcnt" Bart Van Assche
2023-01-31  1:52 ` Ming Lei [this message]
2023-01-31 17:31   ` Bart Van Assche
2023-02-01  1:56     ` Ming Lei
2023-02-01  4:29       ` Ming Lei
2023-02-01 15:55         ` Ming Lei
2023-02-01 20:21           ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9h0WMOqNau4s0c0@T590 \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.