From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Prashant Malani <pmalani@chromium.org>
Cc: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
bleung@chromium.org, heikki.krogerus@linux.intel.com,
Daisuke Nojiri <dnojiri@chromium.org>,
"Dustin L. Howett" <dustin@howett.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Lee Jones <lee@kernel.org>,
Tinghan Shen <tinghan.shen@mediatek.com>
Subject: Re: [PATCH 1/2] platform/chrome: cros_ec: Add VDM attention headers
Date: Tue, 31 Jan 2023 11:19:41 +0800 [thread overview]
Message-ID: <Y9iIzcz5AGjVXsNG@google.com> (raw)
In-Reply-To: <20230126205620.3714994-1-pmalani@chromium.org>
On Thu, Jan 26, 2023 at 08:55:45PM +0000, Prashant Malani wrote:
> Incorporate updates to the EC headers to support the retrieval of VDM
> Attention messages from port partners. These headers are already present
> in the ChromeOS EC codebase. [1]
>
> [1] https://source.chromium.org/chromium/chromiumos/platform/ec/+/main:include/ec_commands.h
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
With a nit:
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
> diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
> index b9c4a3964247..ec327638c6eb 100644
> --- a/include/linux/platform_data/cros_ec_commands.h
> +++ b/include/linux/platform_data/cros_ec_commands.h
> @@ -5862,6 +5862,7 @@ enum tcpc_cc_polarity {
> #define PD_STATUS_EVENT_MUX_1_SET_DONE BIT(5)
> #define PD_STATUS_EVENT_VDM_REQ_REPLY BIT(6)
> #define PD_STATUS_EVENT_VDM_REQ_FAILED BIT(7)
> +#define PD_STATUS_EVENT_VDM_ATTENTION BIT(8)
This has an extra tab if comparing with others around.
next prev parent reply other threads:[~2023-01-31 3:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 20:55 [PATCH 1/2] platform/chrome: cros_ec: Add VDM attention headers Prashant Malani
2023-01-26 20:55 ` [PATCH 2/2] platform/chrome: cros_typec_vdm: Add Attention support Prashant Malani
2023-01-26 21:01 ` Benson Leung
2023-01-27 15:11 ` Heikki Krogerus
2023-01-26 21:00 ` [PATCH 1/2] platform/chrome: cros_ec: Add VDM attention headers Benson Leung
2023-01-31 3:19 ` Tzung-Bi Shih [this message]
2023-01-31 18:21 ` Prashant Malani
2023-01-31 18:20 ` patchwork-bot+chrome-platform
2023-02-07 0:10 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9iIzcz5AGjVXsNG@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dnojiri@chromium.org \
--cc=dustin@howett.net \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=tinghan.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.