All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Yan Cangang <nalanzeyu@gmail.com>
Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty:pty: move wake_up*() after tty_vhangup() in pty_close()
Date: Tue, 31 Jan 2023 10:56:30 +0100	[thread overview]
Message-ID: <Y9jlzjbEGMe/KM55@kroah.com> (raw)
In-Reply-To: <20230127072017.2146403-1-nalanzeyu@gmail.com>

On Fri, Jan 27, 2023 at 03:20:17PM +0800, Yan Cangang wrote:
> wake_up_interruptible() may wake up the session leader blocked on pts, at
> this time the tty_signal_session_leader() in __tty_hangup() has not been
> executed.
> 
> The session leader's subsequent IO on pts will fail, but the session
> leader did not received SIGHUP as expected at this time.
> 
> A observed phenomenon is that when the ssh connection is disconnected, the
> background jobs managed by bash did not terminate as expected. This
> problem is more easily observed on low-end single-processor systems.

This feels odd, why is this only showing up now?  What changed to cause
this issue?

What commit id does this fix?

thanks,

greg k-h

      reply	other threads:[~2023-01-31  9:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27  7:20 [PATCH] tty:pty: move wake_up*() after tty_vhangup() in pty_close() Yan Cangang
2023-01-31  9:56 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9jlzjbEGMe/KM55@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nalanzeyu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.