From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Babis Chalios <bchalios@amazon.es>
Cc: Olivia Mackall <olivia@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, sgarzare@redhat.com,
amit@kernel.org, graf@amazon.de, xmarcalx@amazon.co.uk
Subject: Re: [PATCH v2 0/2] [RFC] virtio-rng entropy leak reporting feature
Date: Tue, 31 Jan 2023 17:27:39 +0100 [thread overview]
Message-ID: <Y9lBeymca9eFaJ33@zx2c4.com> (raw)
In-Reply-To: <20230131145543.86369-1-bchalios@amazon.es>
You sent a v2, but I'm not back until the 11th to provide comments on
v1. I still think this isn't the right direction, as this needs tie-ins
to the rng to actually be useful. Please stop posting new versions of
this for now, so that somebody doesn't accidentally merge it; that'd be
a big mistake. I'll paste what I wrote you prior:
| Hi Babis,
|
| As I mentioned to you privately this week, I'm about to be out of town,
| so I won't be able to look at this until I'm back in a few weeks. I
| appreciate your patience.
|
| But as a cursory look, I'm happy that you've written the hardware-side
| code for this. That's a great starting point. The plumbing is not so
| nice, though. This needs to be integrated more closely with random.c
| itself, similar to how vmgenid works.
|
| When I'm back in a few weeks, I'll see if I can either write a
| description of what I have in mind, or simply integrate the useful
| hardware work here into an expanded patch series.
|
| [Please don't merge anything for now.]
So: you wrote some maybe useful hardware code. The rest is wrong. And we
haven't even concluded discussions on whether the virtio interface is
the right one. In fact, I had previously asked if we could schedule this
all until March. Marco from your team then sent an impatient email, so I
said, alright, what about Feb 11 when I'm back. That's annoying for me
but I figured I'd just shuffle everything around and prioritize this.
Then, instead of waiting for that, you posted v1 of this patchset the
next day. I asked you again. And now, while I'm away on the first
holiday in a while with very little connectivity and no laptop, you post
a v2. So I'm really annoyed. In order to avoid all doubt about this, let
me then just NACK this, and I'll lift the nack when I'm back:
Nacked-by: Jason A. Donenfeld <Jason@zx2c4.com>
next prev parent reply other threads:[~2023-01-31 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 14:55 [PATCH v2 0/2] [RFC] virtio-rng entropy leak reporting feature Babis Chalios
2023-01-31 14:55 ` [PATCH v2 1/2] virtio-rng: implement entropy leak feature Babis Chalios
2023-01-31 14:55 ` [PATCH v2 2/2] virtio-rng: add sysfs entries for leak detection Babis Chalios
2023-01-31 16:27 ` Jason A. Donenfeld [this message]
2023-01-31 17:06 ` [PATCH v2 0/2] [RFC] virtio-rng entropy leak reporting feature bchalios
2023-03-02 16:55 ` Amit Shah
2023-03-02 16:55 ` Amit Shah
2023-03-13 10:42 ` bchalios
2023-03-13 18:05 ` Amit Shah
2023-03-13 18:05 ` Amit Shah
2023-03-20 10:42 ` Amit Shah
2023-03-20 10:42 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9lBeymca9eFaJ33@zx2c4.com \
--to=jason@zx2c4.com \
--cc=amit@kernel.org \
--cc=bchalios@amazon.es \
--cc=graf@amazon.de \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=olivia@selenic.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xmarcalx@amazon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.