From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Jia He <justin.he@arm.com>, Huacai Chen <chenhuacai@kernel.org>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandru Elisei <alexandru.elisei@arm.com>
Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
Date: Tue, 31 Jan 2023 19:03:12 +0100 [thread overview]
Message-ID: <Y9lX4FtlOf2htnxj@zx2c4.com> (raw)
In-Reply-To: <CAMj1kXFTUXgaENBSYh+cGCS3wFCFunf+auk3nKwHVJWiZ7crig@mail.gmail.com>
On Tue, Jan 31, 2023 at 08:18:49AM +0100, Ard Biesheuvel wrote:
> (cc Jason for awareness)
>
> On Tue, 31 Jan 2023 at 05:04, Jia He <justin.he@arm.com> wrote:
> >
> > I met a hung task warning and then kernel was hung forever with latest
> > kernel on an Ampere Emag server.
> >
> > The root cause is kernel was hung when invoking an efi rts call to set
> > the RandomSeed variable during the booting stage. The arch_efi_call_virt
> > call (set_variable) was never returned and then caused the hung task error.
> >
>
> Given that EFI variables work on this platform (as far as I know), the
> problem may be that we are calling SetVariable() too early.
>
On my phone and with very limited connectivity for another 10 days, but
I wonder if there's a later place we could move this block:
if (efi_rt_services_supported(EFI_RT_SUPPORTED_SET_VARIABLE))
execute_with_initialized_rng(&refresh_nv_rng_seed_nb);
Is there any additional initialization that happens after
efisubsys_init() that we're maybe missing out on there?
Jason
next prev parent reply other threads:[~2023-01-31 18:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 4:03 [PATCH 0/2] Fix boot hang issue on Ampere Emag server Jia He
2023-01-31 4:03 ` [PATCH 1/2] efi: libstub: Fix the retriving of supported rutime services Jia He
2023-01-31 7:04 ` Ard Biesheuvel
2023-01-31 4:03 ` [PATCH 2/2] efi: Introduce efi_get_supported_rt_services() to get the runtime services mask Jia He
2023-01-31 7:06 ` Ard Biesheuvel
2023-01-31 7:18 ` [PATCH 0/2] Fix boot hang issue on Ampere Emag server Ard Biesheuvel
2023-01-31 15:21 ` Justin He
2023-01-31 15:31 ` Justin He
2023-01-31 18:23 ` Jason A. Donenfeld
2023-02-02 10:50 ` Justin He
2023-02-07 3:21 ` Justin He
2023-02-07 8:44 ` Ard Biesheuvel
2023-02-07 8:49 ` Justin He
2023-02-07 8:54 ` Ard Biesheuvel
2023-02-07 9:02 ` Justin He
2023-02-07 9:03 ` Ard Biesheuvel
2023-02-07 9:08 ` Justin He
2023-02-07 9:09 ` Ard Biesheuvel
2023-02-08 3:10 ` Justin He
2023-01-31 18:03 ` Jason A. Donenfeld [this message]
2023-01-31 18:13 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9lX4FtlOf2htnxj@zx2c4.com \
--to=jason@zx2c4.com \
--cc=alexandru.elisei@arm.com \
--cc=ardb@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=justin.he@arm.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.