Re: [lee-mfd:for-mfd-next 36/37] drivers/mmc/host/tmio_mmc.c:141:12: error: no member named 'enable' in 'struct mfd_cell'

[Lee Jones <lee@kernel.org>]

On Tue, 31 Jan 2023, Uwe Kleine-König wrote:

> On Tue, Jan 31, 2023 at 05:17:19PM +0000, Lee Jones wrote:
> > On Tue, 31 Jan 2023, Uwe Kleine-König wrote:
> > 
> > > Hello,
> > > 
> > > On Tue, Jan 31, 2023 at 10:48:48PM +0800, kernel test robot wrote:
> > > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
> > > > head:   a561a980c024193e342b6878f62e02ff9d018285
> > > > commit: 78e7ccec94380519919267670174cbf1711b7963 [36/37] mfd: Remove .enable() and .disable() callbacks
> > > > config: hexagon-randconfig-r041-20230130 (https://download.01.org/0day-ci/archive/20230131/202301312253.oUVq9cys-lkp@intel.com/config)
> > > > compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 4196ca3278f78c6e19246e54ab0ecb364e37d66a)
> > > > reproduce (this is a W=1 build):
> > > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > >         chmod +x ~/bin/make.cross
> > > >         # https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?id=78e7ccec94380519919267670174cbf1711b7963
> > > >         git remote add lee-mfd https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
> > > >         git fetch --no-tags lee-mfd for-mfd-next
> > > >         git checkout 78e7ccec94380519919267670174cbf1711b7963
> > > >         # save the config file
> > > >         mkdir build_dir && cp config build_dir/.config
> > > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig
> > > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mmc/host/ drivers/video/fbdev/
> > > > 
> > > > If you fix the issue, kindly add following tag where applicable
> > > > | Reported-by: kernel test robot <lkp@intel.com>
> > > > 
> > > > All errors (new ones prefixed by >>):
> > > > 
> > > > [...]
> > > > >> drivers/mmc/host/tmio_mmc.c:186:12: error: no member named 'disable' in 'struct mfd_cell'
> > > >            if (cell->disable)
> > > >                ~~~~  ^
> > > 
> > > This driver doesn't exist in next any more (commit ecb92c1f4752). So I'm
> > > unsure what to do here.
> > > 
> > > The obvious (to me) options are:
> > > 
> > >  a) ignore the problem
> > >  b) merge ecb92c1f4752 into mfd before applying "mfd: Remove .enable()
> > >     and .disable() callbacks"
> > >  c) drop "mfd: Remove .enable() and .disable() callbacks" for now and
> > >     reapply when ecb92c1f4752 is in Linus' tree (variant of b))
> > > 
> > > Lee, what's your take here?
> > 
> > We need to pull your patch for now.
> 
> I guess that means c), right?

Yes, for now.

Please re-submit once we're in better shape.

> > See:
> > 
> >   drivers/mmc/host/tmio_mmc.c
> >   drivers/mtd/nand/raw/tmio_nand.c
> >   drivers/usb/host/ohci-tmio.c
> >   drivers/video/fbdev/tmiofb.c
> >   drivers/w1/masters/ds1wm.c
> 
> Huh, I only checked the first and wonder how I missed these. I guess I
> checked next only that already has these all dropped. Sorry.

-- 
Lee Jones [李琼斯]