From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8055C05027 for ; Thu, 2 Feb 2023 10:29:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232577AbjBBK3u (ORCPT ); Thu, 2 Feb 2023 05:29:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231575AbjBBK3t (ORCPT ); Thu, 2 Feb 2023 05:29:49 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CE6D2DE6E for ; Thu, 2 Feb 2023 02:29:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 38F7260B5A for ; Thu, 2 Feb 2023 10:29:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 497E6C433D2; Thu, 2 Feb 2023 10:29:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675333787; bh=7Fz6AqVt+ciPlBbDSzJN6ngOgZH4aTHSZbvVJwiDaC8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MVNrVUJYCMdN9py3qr6yJKMhk0LIq1CpTDZGhdBNsyLIEPoAShn0/0028bwu+qOw6 jCtse+iitXRatd+c5/rn1FO2SstQIkQu54B8WmP8BbeSHE3dpKgmSbG9+BT3nRiO4v IGKzOGaP6bRGnsDcqXSCgpiU/EZlLORBskQPz10g= Date: Thu, 2 Feb 2023 11:29:44 +0100 From: Greg KH To: Dan Scally Cc: linux-usb@vger.kernel.org, laurent.pinchart@ideasonboard.com, w36195@motorola.com, m.grzeschik@pengutronix.de, kieran.bingham@ideasonboard.com, torleiv@huddly.com Subject: Re: [PATCH v3 0/7] UVC Gadget: Extend color matching support Message-ID: References: <20230130142639.217885-1-dan.scally@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Feb 02, 2023 at 10:20:20AM +0000, Dan Scally wrote: > Morning Greg > > On 02/02/2023 10:18, Greg KH wrote: > > On Mon, Jan 30, 2023 at 02:26:32PM +0000, Daniel Scally wrote: > > > The current UVC gadget implementation hardcodes a single color matching > > > descriptor and includes it in the payload of USB descriptors a single time > > > following all the format and frame descriptors. This is inflexible, and > > > additionally applies only to the _last_ format in the array of descriptors. > > > > > > This series extends the support such that the default descriptor can be amended > > > and is included once-per-format instead of once-only, it then adds the ability > > > to create new color matching descriptors and associate them with particular formats. > > > The default color matching descriptor is retained and used where the user does not > > > link a new color matching descriptor to the format, so the default interaction > > > with userspace is unchanged from the current implementation. > > > > > > Daniel Scally (7): > > > usb: gadget: usb: Remove "default" from color matching attributes > > > usb: uvc: Enumerate valid values for color matching > > > usb: gadget: uvc: Add struct for color matching in configs > > > usb: gadget: uvc: Copy color matching descriptor for each frame > > > usb: gadget: uvc: Remove the hardcoded default color matching > > > usb: gadget: uvc: Make color matching attributes read/write > > > usb: gadget: uvc: Allow creating new color matching descriptors > > > > > > .../ABI/testing/configfs-usb-gadget-uvc | 19 +- > > > drivers/usb/gadget/function/f_uvc.c | 9 - > > > drivers/usb/gadget/function/u_uvc.h | 1 - > > > drivers/usb/gadget/function/uvc_configfs.c | 282 ++++++++++++++++-- > > > drivers/usb/gadget/function/uvc_configfs.h | 22 +- > > > include/uapi/linux/usb/video.h | 30 ++ > > > 6 files changed, 315 insertions(+), 48 deletions(-) > > > > > > -- > > > 2.34.1 > > > > > This series does not apply against my tree at all, what was it made > > against? > > > I thought I had rebased it against usb-linus, was that the wrong branch to > use? If not then I probably messed it up somehow, I can rebase and resend. usb-linus is not the right branch for new features, please use usb-next. Although for the next 24 hours, you should probably use usb-testing as that has your other changes in it already, before I merge it into usb-next. thanks, greg k-h