From: Greg KH <gregkh@linuxfoundation.org>
To: Viken Dadhaniya <quic_vdadhani@quicinc.com>
Cc: jirislaby@kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_msavaliy@quicinc.com,
quic_vnivarth@quicinc.com, quic_vtanuku@quicinc.com,
quic_arandive@quicinc.com
Subject: Re: [PATCH V2] Serial: core: Add compat ioctl support
Date: Thu, 2 Feb 2023 11:32:33 +0100 [thread overview]
Message-ID: <Y9uRQb72Y7byQiXa@kroah.com> (raw)
In-Reply-To: <10d91214-4106-7a9d-b1ac-68df1aa5f6c9@quicinc.com>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Feb 02, 2023 at 03:44:45PM +0530, Viken Dadhaniya wrote:
> Hi Greg,
>
> "Can you point us at the out-of-tree code please?"
>
> Please refer: https://git.codelinaro.org/clo/la/kernel/msm-5.10/-/blob/KERNEL.PLATFORM.1.0.r3-01300-kernel.0/drivers/tty/serial/msm_geni_serial.c#L750
As this is a 5.10 link, are you sure this is the same codebase you are
using?
That ioctl handler does not touch the arg parameter at all, so what
would a compat_ioctl() handler be required for?
confused,
greg k-h
prev parent reply other threads:[~2023-02-02 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 11:34 [PATCH V2] Serial: core: Add compat ioctl support Viken Dadhaniya
2023-01-25 12:24 ` Greg KH
2023-02-02 10:14 ` Viken Dadhaniya
2023-02-02 10:32 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9uRQb72Y7byQiXa@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=quic_arandive@quicinc.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=quic_vnivarth@quicinc.com \
--cc=quic_vtanuku@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.