From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFAFDC636D4 for ; Thu, 2 Feb 2023 16:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675356648; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xSBVDvzpmg3Nfzc+wbV/iX0gvakx5Fz1a4YQWJosTIk=; b=imy+3WD4hxjdaYDTBYwspLCEpNw1F2ByVqxEUVfxqu8M3hhKeWenSQ4FUtEvEUEmh0gyP9 HWHmick7w601zaT0TpB1iuaDoO/hCYi4+YXBTC4xpI41p6elihytZRIIuITe0pFXvW03bu DxJzS74hkM68Ho++RD5uaeh1m3uFxhQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-634-gOnHkng3NsW2Y_fiyPsq7w-1; Thu, 02 Feb 2023 11:50:45 -0500 X-MC-Unique: gOnHkng3NsW2Y_fiyPsq7w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0FC19101B450; Thu, 2 Feb 2023 16:50:43 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id B426F492C3E; Thu, 2 Feb 2023 16:50:42 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8296E194658C; Thu, 2 Feb 2023 16:50:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6B1DA1946586 for ; Thu, 2 Feb 2023 16:50:41 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 4D6B62026D76; Thu, 2 Feb 2023 16:50:41 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45D0F2026D68 for ; Thu, 2 Feb 2023 16:50:41 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2526C29AA387 for ; Thu, 2 Feb 2023 16:50:41 +0000 (UTC) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-151-N32QzFHlPQqKY_UmfcwKzQ-1; Thu, 02 Feb 2023 11:50:39 -0500 X-MC-Unique: N32QzFHlPQqKY_UmfcwKzQ-1 Received: by mail-qt1-f169.google.com with SMTP id h24so2585551qtr.0 for ; Thu, 02 Feb 2023 08:50:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1tztcBchRZ+ahQ+Rv8slGEZ3rlEReGoboay+wBElNpk=; b=Eb/D4GrYB8MJmHqNIE/vpCwVfJPSkGOEH8U3KAYgOZ2+rRfuPrmPYqmmkMGtPQiTb3 4fgi1IRo7OccnjSvnKG937VIfKsDpz1c/+QKvCLfEuAJhwGQ5LUhfHSje8oilHkHe908 0ryrZfgBfY+8U065oJKJly/qgJ+RuHxoAcAP3Hqo1oQLLnfA+T+hAbjqBhRKRfApbKBL TM9I9a81By4Uj3R0PLbez/TLZgK9+mGiHJLhqF1hC6ys/5fuCEX8l4u7dVQI2Rrpm7y8 Lh/l6oua/gyWe9UcqGMBVoR0X0rEtJMxNg4adx/WPd3YCqeiDLJVXwU2ySaGRMNQ7thE m6Qg== X-Gm-Message-State: AO0yUKUGrULQF+i60fmIJ//KjwNhDL51mblcsfvhe8FXf9ihR+Lx9XiU bNllwEPNHulXRXoFRA4VSqd3Z/o= X-Google-Smtp-Source: AK7set+4Pyeb5ompgmUg0JYUv54bCb2ceknHgU0XW/UAy594tQAOCFstY5279x2+bA/W3Ae7xhvLGQ== X-Received: by 2002:a05:622a:1788:b0:3b8:2ea9:a093 with SMTP id s8-20020a05622a178800b003b82ea9a093mr13141578qtk.1.1675356639078; Thu, 02 Feb 2023 08:50:39 -0800 (PST) Received: from localhost (pool-68-160-166-30.bstnma.fios.verizon.net. [68.160.166.30]) by smtp.gmail.com with ESMTPSA id t9-20020a05620a034900b0071eddd3bebbsm31687qkm.81.2023.02.02.08.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 08:50:38 -0800 (PST) Date: Thu, 2 Feb 2023 11:50:37 -0500 From: Mike Snitzer To: Demi Marie Obenour Message-ID: References: <20230126033358.1880-1-demi@invisiblethingslab.com> MIME-Version: 1.0 In-Reply-To: <20230126033358.1880-1-demi@invisiblethingslab.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Subject: Re: [dm-devel] [RFC PATCH 0/7] Allow race-free block device handling X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Juergen Gross , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, dm-devel@redhat.com, xen-devel@lists.xenproject.org, Alasdair Kergon , Roger Pau =?iso-8859-1?Q?Monn=E9?= Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gV2VkLCBKYW4gMjUgMjAyMyBhdCAxMDozM1AgLTA1MDAsCkRlbWkgTWFyaWUgT2Jlbm91ciA8 ZGVtaUBpbnZpc2libGV0aGluZ3NsYWIuY29tPiB3cm90ZToKCj4gVGhpcyB3b3JrIGFpbXMgdG8g YWxsb3cgdXNlcnNwYWNlIHRvIGNyZWF0ZSBhbmQgZGVzdHJveSBibG9jayBkZXZpY2VzCj4gaW4g YSByYWNlLWZyZWUgYW5kIGxlYWstZnJlZSB3YXksCgoicmFjZS1mcmVlIGFuZCBsZWFrLWZyZWUg d2F5IiBpbXBsaWVzIHRoZXJlIGJvdGggcmFjZXMgYW5kIGxlYWtzIGluCmV4aXN0aW5nIGNvZGUu IFlvdSdyZSBtYWtpbmcgY2xhaW1zIHRoYXQgYXJlIGxpa2VseSB2ZXJ5IHNwZWNpZmljIHRvCnlv dXIgWGVuIHVzZS1jYXNlLiAgUGxlYXNlIGV4cGxhaW4gbW9yZSBjYXJlZnVsbHkuCgo+IGFuZCB0 byBhbGxvdyB0aGVtIHRvIGJlIGV4cG9zZWQgdG8KPiBvdGhlciBYZW4gVk1zIHZpYSBibGtiYWNr IHdpdGhvdXQgbGVha3Mgb3IgcmFjZXMuICBJdOKAmXMgbWFya2VkIGFzIFJGQwo+IGZvciBhIGZl dyByZWFzb25zOgo+IAo+IC0gVGhlIGNvZGUgaGFzIGJlZW4gb25seSBsaWdodGx5IHRlc3RlZC4g IEl0IG1pZ2h0IGJlIHVuc3RhYmxlIG9yCj4gICBpbnNlY3VyZS4KPiAKPiAtIFRoZSBETV9ERVZf Q1JFQVRFIGlvY3RsIGdhaW5zIGEgbmV3IGZsYWcuICBVbmtub3duIGZsYWdzIHdlcmUKPiAgIHBy ZXZpb3VzbHkgaWdub3JlZCwgc28gdGhpcyBjb3VsZCB0aGVvcmV0aWNhbGx5IGJyZWFrIGJ1Z2d5 IHVzZXJzcGFjZQo+ICAgdG9vbHMuCgpOb3Qgc2VlaW5nIGEgcmVhc29uIHRoYXQgdHlwZSBvZiBE TSBjaGFuZ2UgaXMgbmVlZGVkLiBJZiB5b3UgZmVlbApzdHJvbmdseSBhYm91dCBpdCBzZW5kIGEg c2VwYXJhdGUgcGF0Y2ggYW5kIHdlIGNhbiBkaXNjdXNzIGl0LgoKPiAtIEkgaGF2ZSBubyBpZGVh IGlmIEkgZ290IHRoZSBibG9jayBkZXZpY2UgcmVmZXJlbmNlIGNvdW50aW5nIGFuZAo+ICAgbG9j a2luZyBjb3JyZWN0LgoKWW91ciBoZWFkZXJzIGFuZCBqdXN0aWZjYXRpb24gZm9yIHRoaXMgbGlu ZSBvZiB3b3JrIGFyZSByZWFsbHkgd2F5IHRvbwp0ZXJzZS4gUGxlYXNlIHRha2UgdGhlIHRpbWUg dG8gY2xlYXJseSBtYWtlIHRoZSBjYXNlIGZvciB5b3VyIGNoYW5nZXMKaW4gYm90aCB0aGUgcGF0 Y2ggaGVhZGVycyBhbmQgY29kZS4KCk1pa2UKCi0tCmRtLWRldmVsIG1haWxpbmcgbGlzdApkbS1k ZXZlbEByZWRoYXQuY29tCmh0dHBzOi8vbGlzdG1hbi5yZWRoYXQuY29tL21haWxtYW4vbGlzdGlu Zm8vZG0tZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB2D8C05027 for ; Thu, 2 Feb 2023 16:51:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232361AbjBBQv1 (ORCPT ); Thu, 2 Feb 2023 11:51:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232356AbjBBQv0 (ORCPT ); Thu, 2 Feb 2023 11:51:26 -0500 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01F846D5D7 for ; Thu, 2 Feb 2023 08:50:40 -0800 (PST) Received: by mail-qt1-f181.google.com with SMTP id m26so2503350qtp.9 for ; Thu, 02 Feb 2023 08:50:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1tztcBchRZ+ahQ+Rv8slGEZ3rlEReGoboay+wBElNpk=; b=V65m8bLeKyomRle8R1oVGJUm8ix6KUU1yFpdYC/oIP9+vA8K/rtDRq3erNqvoaiz1P uxVx6NrlDCldHPpzSBUC3nvoU4LH2+qtB+JN1sBEyn0yIG0C+pgCY+Od7Yg/bdcmubz8 8nTJeq/o7YinhTl4qYJ0B0U2LGji7Tw29dT2ObC/Lamg3x1ZFnp7s8CZpNiXpiwLptP3 gP3MmhWXkN5ObLxoo03DRY57B/5w8VTPTxS1CbtlPZGAvbukGV2XaeUF2gAw/cuD5MWd GxwWBPM0y5a9RMMQ25Jg3tLE0dtW1BqGdEVjTcewazcPV59oIW2LdZwA9iwaJwSX6+4u PQgQ== X-Gm-Message-State: AO0yUKUW0zuP98HDwCLuu2vEgk3hE8Q47kTFYIJIdmqovzwAFxvQlgHs c9yDk+tY/XBUFxxbxpNZmJwn X-Google-Smtp-Source: AK7set+4Pyeb5ompgmUg0JYUv54bCb2ceknHgU0XW/UAy594tQAOCFstY5279x2+bA/W3Ae7xhvLGQ== X-Received: by 2002:a05:622a:1788:b0:3b8:2ea9:a093 with SMTP id s8-20020a05622a178800b003b82ea9a093mr13141578qtk.1.1675356639078; Thu, 02 Feb 2023 08:50:39 -0800 (PST) Received: from localhost (pool-68-160-166-30.bstnma.fios.verizon.net. [68.160.166.30]) by smtp.gmail.com with ESMTPSA id t9-20020a05620a034900b0071eddd3bebbsm31687qkm.81.2023.02.02.08.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 08:50:38 -0800 (PST) Date: Thu, 2 Feb 2023 11:50:37 -0500 From: Mike Snitzer To: Demi Marie Obenour Cc: Jens Axboe , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Alasdair Kergon , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , Juergen Gross , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, dm-devel@redhat.com Subject: Re: [RFC PATCH 0/7] Allow race-free block device handling Message-ID: References: <20230126033358.1880-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230126033358.1880-1-demi@invisiblethingslab.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Jan 25 2023 at 10:33P -0500, Demi Marie Obenour wrote: > This work aims to allow userspace to create and destroy block devices > in a race-free and leak-free way, "race-free and leak-free way" implies there both races and leaks in existing code. You're making claims that are likely very specific to your Xen use-case. Please explain more carefully. > and to allow them to be exposed to > other Xen VMs via blkback without leaks or races. It’s marked as RFC > for a few reasons: > > - The code has been only lightly tested. It might be unstable or > insecure. > > - The DM_DEV_CREATE ioctl gains a new flag. Unknown flags were > previously ignored, so this could theoretically break buggy userspace > tools. Not seeing a reason that type of DM change is needed. If you feel strongly about it send a separate patch and we can discuss it. > - I have no idea if I got the block device reference counting and > locking correct. Your headers and justifcation for this line of work are really way too terse. Please take the time to clearly make the case for your changes in both the patch headers and code. Mike