From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04CD7C61DA4 for ; Thu, 2 Feb 2023 18:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z4J0YEVwuehYB95D87QUResmIf9WaWbc8mwLbE7ppBk=; b=BWIDoslNO+Qdyz v33TvDpOKlt/NRjGJU4O3Gu4/tMmRmL+HQZpkfZKhja/dAhtX6mbbK2u4hJ0MnGxae3Txp+qwtsev wHYw467BJ7TEMUivfJ8xs+8AYq94pNijyNhBph4n1D8tXlURlNRFCZx4GKnCyI1FXXEpmoe1LkZ3i fS5fSPmocyJ0ZsN3dvOHnMCxJsHKvy4YysThzvzA/JyM5KQ6n25pYajIrKon6RNdAQI1vfShXF7T0 z79NYPkzY2EByb1i5IBkp4TNSxAXuyf+KTV4sLXDKpVwgek6pDQOy/zOjSvdB5sq+2x4/deEc9zvs RXV9Dm7dx5QyBwogmFOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNegY-00H0Jt-On; Thu, 02 Feb 2023 18:51:50 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNegV-00H0J3-SM for linux-arm-kernel@lists.infradead.org; Thu, 02 Feb 2023 18:51:49 +0000 Received: by mail-pj1-x102c.google.com with SMTP id cl23-20020a17090af69700b0022c745bfdc3so2699389pjb.3 for ; Thu, 02 Feb 2023 10:51:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4bhsb2fuNBYHSupvvVBEu0/2p/VPgtQRHARS0fdgrQw=; b=fl54cRpow83IgMccmr8VLx+5n6ALA6aKE7LvaqSpcL0YwJW0bFklnlB8hQXu4VcTVW gItWqrnMYNO9QNdUxMVUI9EoAZl8tr2NveBRgvf1gserVwkApBhu/ayywcdjYpxZjmDO eZf+eHZqzLO8do22o3NrXU6v1b5PyZ/cRs67oe9g7uE5GG8Rffuydw/rAUj02Wb/KGP8 LyPt47y9yJJo1CgIrwXb0JCh+A2tAfXvVZoEsydT7QlQBQWzUJ01tsKMi9vrhxFWm6vj LqPt7IVfX7KGWOUL6HE/SbP3ZepXr/sbBWF2NPAbAFWZ5hrZznIFjCjL1GyGtDcS3W70 NE7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4bhsb2fuNBYHSupvvVBEu0/2p/VPgtQRHARS0fdgrQw=; b=zPMv8IKSmyxWBbPmdicq6HxlGYfZvelJTCNL6a71CzfrHikn7D87Y9umdcrcNSVQAa rFMb0gO2n7wI2i5bDPy3qGcZlPSQCwgMf2+cGP7X1rk+cA995M+OjFCtpMPD8/SwiB6g bMcv0gpQF0QLEKPAp7bGwn7f4kVUDf17T9mbn9bWP3uQFr6IicGjA2eId3Opw6qZaGVL YBgyIhn5A9I8sAhFmJRCdSYcvglRbkpEYGWp/UL4M3OxsJpXjnBruZUX7Y0DyA85oxou ZpZ8iTXbBpnnDvsPEpVA0lMZyZLe8xfMPRtaTvQh0J/QQiC9t2b+teYOpF3854l7MumF PThQ== X-Gm-Message-State: AO0yUKWHO9XKuRwWHA2sLO1z8TAM6fH/fOa0s5+V3tEDdZBw6Jlu0OSd tujBTnrdUD5Yp2ajfpn5tDQ= X-Google-Smtp-Source: AK7set/wqo5Bc3GMCe1/MUkp7nQGbr3XI+EomgafXQ2z1Flem72j6vha4fXv9v355t8kF+fn2LG8bQ== X-Received: by 2002:a17:90b:3a86:b0:22c:9782:e718 with SMTP id om6-20020a17090b3a8600b0022c9782e718mr7623682pjb.0.1675363903802; Thu, 02 Feb 2023 10:51:43 -0800 (PST) Received: from google.com ([2620:15c:9d:2:6b75:4990:9ed8:d8dc]) by smtp.gmail.com with ESMTPSA id fw2-20020a17090b128200b0022c01ab2899sm176362pjb.49.2023.02.02.10.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 10:51:43 -0800 (PST) Date: Thu, 2 Feb 2023 10:51:39 -0800 From: Dmitry Torokhov To: Patrice Chotard Cc: Rob Herring , Krzysztof Kozlowski , Alain Volmat , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_105147_934117_11FD33EC X-CRM114-Status: GOOD ( 20.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 30, 2022 at 09:00:41AM -0700, Dmitry Torokhov wrote: > According to c8sectpfe driver code we first drive reset line low and > then high to reset the port, therefore the reset line is supposed to > be annotated as "active low". This will be important when we convert > the driver to gpiod API. > > Reviewed-by: Patrice Chotard > Signed-off-by: Dmitry Torokhov > --- Gentle ping on this one... > > v2: fixed typo in the subject, added Patrice's reviewed-by > > arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi > index 2aa94605d3d4..d52a7aaa1074 100644 > --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi > +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi > @@ -178,7 +178,7 @@ tsin0: port { > tsin-num = <0>; > serial-not-parallel; > i2c-bus = <&ssc2>; > - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>; > dvb-card = ; > }; > }; > -- > 2.38.0.rc1.362.ged0d419d3c-goog > > > -- > Dmitry -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C135C05027 for ; Thu, 2 Feb 2023 18:51:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231546AbjBBSvq (ORCPT ); Thu, 2 Feb 2023 13:51:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232387AbjBBSvp (ORCPT ); Thu, 2 Feb 2023 13:51:45 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B261940DF; Thu, 2 Feb 2023 10:51:44 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id f16-20020a17090a9b1000b0023058bbd7b2so2100264pjp.0; Thu, 02 Feb 2023 10:51:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4bhsb2fuNBYHSupvvVBEu0/2p/VPgtQRHARS0fdgrQw=; b=fl54cRpow83IgMccmr8VLx+5n6ALA6aKE7LvaqSpcL0YwJW0bFklnlB8hQXu4VcTVW gItWqrnMYNO9QNdUxMVUI9EoAZl8tr2NveBRgvf1gserVwkApBhu/ayywcdjYpxZjmDO eZf+eHZqzLO8do22o3NrXU6v1b5PyZ/cRs67oe9g7uE5GG8Rffuydw/rAUj02Wb/KGP8 LyPt47y9yJJo1CgIrwXb0JCh+A2tAfXvVZoEsydT7QlQBQWzUJ01tsKMi9vrhxFWm6vj LqPt7IVfX7KGWOUL6HE/SbP3ZepXr/sbBWF2NPAbAFWZ5hrZznIFjCjL1GyGtDcS3W70 NE7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4bhsb2fuNBYHSupvvVBEu0/2p/VPgtQRHARS0fdgrQw=; b=PvMCytJgB2K3/Z3t13s3J1WgtJoycfKmabseU1YAU6s4Y/LLvMVgZL88XwGC/dwR8g fw42W3U6OvR75j6mXn8EWxlBzDtSyr00Rdmx1bDtGT7+stKEnzVs8JhrfVjQnkqY4HSh Seuf+kcaHtIvPKaxznByRSnyXPb2g20QYCX/3hBetyKhOvI2PZxT7m5XHAwOlhXMcTQt h5rZpswhO+MJhkMdnoEs7U9jKKSWd8zonZW6YPc0IX06gQPO7DtecU39AkSww1jd9pRX r3uL3dLn5c+nIDDXEph/ySet5A4c5e/XyZyer6/IFP7Tbc3byawaskrmZ3buKnmY+9yX 4uiQ== X-Gm-Message-State: AO0yUKUnWKS53BrchkVYq9n+Zk3RSVm3XKiP7KoTP01VnvFyKo5be8KQ DoWpCyPUeHB0Wvy6S9OmHjXrSlraLY4= X-Google-Smtp-Source: AK7set/wqo5Bc3GMCe1/MUkp7nQGbr3XI+EomgafXQ2z1Flem72j6vha4fXv9v355t8kF+fn2LG8bQ== X-Received: by 2002:a17:90b:3a86:b0:22c:9782:e718 with SMTP id om6-20020a17090b3a8600b0022c9782e718mr7623682pjb.0.1675363903802; Thu, 02 Feb 2023 10:51:43 -0800 (PST) Received: from google.com ([2620:15c:9d:2:6b75:4990:9ed8:d8dc]) by smtp.gmail.com with ESMTPSA id fw2-20020a17090b128200b0022c01ab2899sm176362pjb.49.2023.02.02.10.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 10:51:43 -0800 (PST) Date: Thu, 2 Feb 2023 10:51:39 -0800 From: Dmitry Torokhov To: Patrice Chotard Cc: Rob Herring , Krzysztof Kozlowski , Alain Volmat , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Sep 30, 2022 at 09:00:41AM -0700, Dmitry Torokhov wrote: > According to c8sectpfe driver code we first drive reset line low and > then high to reset the port, therefore the reset line is supposed to > be annotated as "active low". This will be important when we convert > the driver to gpiod API. > > Reviewed-by: Patrice Chotard > Signed-off-by: Dmitry Torokhov > --- Gentle ping on this one... > > v2: fixed typo in the subject, added Patrice's reviewed-by > > arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi > index 2aa94605d3d4..d52a7aaa1074 100644 > --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi > +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi > @@ -178,7 +178,7 @@ tsin0: port { > tsin-num = <0>; > serial-not-parallel; > i2c-bus = <&ssc2>; > - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>; > dvb-card = ; > }; > }; > -- > 2.38.0.rc1.362.ged0d419d3c-goog > > > -- > Dmitry -- Dmitry