From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control Date: Thu, 2 Feb 2023 10:00:14 -1000 Message-ID: References: <20230112165609.1083270-1-tvrtko.ursulin@linux.intel.com> <20230112165609.1083270-11-tvrtko.ursulin@linux.intel.com> <27b7882e-1201-b173-6f56-9ececb5780e8@linux.intel.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=KTEXTLdEtQvrB7aVFpBYAbH4Vf/ihPabgDflRw+s72o=; b=CuJhJ9UTVuPY/jraolwLg+hw6h/pKxRy1SLRd/hEO8GnE3cDoiPidADrjRGw4Tat7E jsPj+B5/JWPEzkR1ov2cP4QLjkGjelgudaCyhdc4WTw+8Tb5Oonu+M6rmd85VoAp+09n p29yqXXOCqF9Y85uU7Om7KJ2ttMYgVWNGXZB9YxNzDvxDzbpksNHc1G+p86CxKdlN0Ty +rwXXExzAQPU5AL4D29Etk7FWGP466Or/Daf4dCE9QSEqudpR8qq8SpggqjYy48/R5Nd XYVHbi+FsHBVz+Wv+DIRXgY0DRGWK3xQsCPpOzfidwB7nrd2hKVFHAH562MKRavuNJmY xtXQ== Sender: Tejun Heo Content-Disposition: inline In-Reply-To: <27b7882e-1201-b173-6f56-9ececb5780e8-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tvrtko Ursulin Cc: Intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Johannes Weiner , Zefan Li , Dave Airlie , Daniel Vetter , Rob Clark , =?iso-8859-1?Q?St=E9phane?= Marchesin , "T . J . Mercier" , Kenny.Ho-5C7GfCeVMHo@public.gmane.org, Christian =?iso-8859-1?Q?K=F6nig?= , Brian Welty , Tvrtko Ursulin Hello, On Thu, Feb 02, 2023 at 02:26:06PM +0000, Tvrtko Ursulin wrote: > When you say active/inactive - to what you are referring in the cgroup > world? Offline/online? For those my understanding was offline was a > temporary state while css is getting destroyed. Oh, it's just based on activity. So, for example, iocost puts a cgroup on its active list which is canned periodically when an IO is issued from an inactive cgroup. If an active cgroup doesn't have any activity between two scans, it becomes inactive and dropped from the list. drm can prolly use the same approach? > Also, I am really postponing implementing those changes until I hear at > least something from the DRM community. Yeah, that sounds like a good idea. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B2C1C05027 for ; Thu, 2 Feb 2023 20:00:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DDD2210E619; Thu, 2 Feb 2023 20:00:17 +0000 (UTC) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD49D10E614; Thu, 2 Feb 2023 20:00:16 +0000 (UTC) Received: by mail-pl1-x62e.google.com with SMTP id z1so3010584plg.6; Thu, 02 Feb 2023 12:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=KTEXTLdEtQvrB7aVFpBYAbH4Vf/ihPabgDflRw+s72o=; b=CuJhJ9UTVuPY/jraolwLg+hw6h/pKxRy1SLRd/hEO8GnE3cDoiPidADrjRGw4Tat7E jsPj+B5/JWPEzkR1ov2cP4QLjkGjelgudaCyhdc4WTw+8Tb5Oonu+M6rmd85VoAp+09n p29yqXXOCqF9Y85uU7Om7KJ2ttMYgVWNGXZB9YxNzDvxDzbpksNHc1G+p86CxKdlN0Ty +rwXXExzAQPU5AL4D29Etk7FWGP466Or/Daf4dCE9QSEqudpR8qq8SpggqjYy48/R5Nd XYVHbi+FsHBVz+Wv+DIRXgY0DRGWK3xQsCPpOzfidwB7nrd2hKVFHAH562MKRavuNJmY xtXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KTEXTLdEtQvrB7aVFpBYAbH4Vf/ihPabgDflRw+s72o=; b=cOd056a/GrX8pDWiMPmEczovXW5fRre5zYkRDlcnSekjPs8L9PBKpMH2rItQHddIJa zxZMKG68YT/e828qzS7lxnB3WJqVIf8h+jlVLkdqfvj7/BmUz722xTeyuGZCqQaLLosN oMkySNy1o0Bk7Gg2plZ1uNIZ3/BAsTOKyk33lhBzxGz72sxGq0fbc/y3cPMxemITxwmy o+rhN668Uyp8C//Jl9Yz1QKu2Jhr8ft/0qS+fdagAacdrgblmlNnly/ilzEJU3OCYlyB rjMYTeYgd5wknFO42NySWrBeShp288n48Fm7GUsRxGhcL8y/d66pmMqZ+vi4TrzFe4iS aASw== X-Gm-Message-State: AO0yUKVVM6tNk8TWqBYloZd1h3HXfzZvYt05O93EUWsAz0K1MuB8ogYS U6ZjEIEJFq2+A4yPVW5BWm4= X-Google-Smtp-Source: AK7set8Q9bsQxt4cyQu1ye65OLJScIues9R6Sdz55WQAGcTEZjBv9qXC8qRJpwpjQ6p92muQd2Vhww== X-Received: by 2002:a17:903:1111:b0:196:6ec4:52db with SMTP id n17-20020a170903111100b001966ec452dbmr8506618plh.51.1675368016015; Thu, 02 Feb 2023 12:00:16 -0800 (PST) Received: from localhost ([2620:10d:c090:400::5:48a9]) by smtp.gmail.com with ESMTPSA id 10-20020a170902c14a00b001933b4b1a49sm53850plj.183.2023.02.02.12.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 12:00:15 -0800 (PST) Date: Thu, 2 Feb 2023 10:00:14 -1000 From: Tejun Heo To: Tvrtko Ursulin Message-ID: References: <20230112165609.1083270-1-tvrtko.ursulin@linux.intel.com> <20230112165609.1083270-11-tvrtko.ursulin@linux.intel.com> <27b7882e-1201-b173-6f56-9ececb5780e8@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27b7882e-1201-b173-6f56-9ececb5780e8@linux.intel.com> Subject: Re: [Intel-gfx] [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Kenny.Ho@amd.com, Dave Airlie , =?iso-8859-1?Q?St=E9phane?= Marchesin , Daniel Vetter , Intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= , Zefan Li , Johannes Weiner , cgroups@vger.kernel.org, "T . J . Mercier" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hello, On Thu, Feb 02, 2023 at 02:26:06PM +0000, Tvrtko Ursulin wrote: > When you say active/inactive - to what you are referring in the cgroup > world? Offline/online? For those my understanding was offline was a > temporary state while css is getting destroyed. Oh, it's just based on activity. So, for example, iocost puts a cgroup on its active list which is canned periodically when an IO is issued from an inactive cgroup. If an active cgroup doesn't have any activity between two scans, it becomes inactive and dropped from the list. drm can prolly use the same approach? > Also, I am really postponing implementing those changes until I hear at > least something from the DRM community. Yeah, that sounds like a good idea. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BCA7C636D3 for ; Thu, 2 Feb 2023 20:00:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5C3210E614; Thu, 2 Feb 2023 20:00:17 +0000 (UTC) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD49D10E614; Thu, 2 Feb 2023 20:00:16 +0000 (UTC) Received: by mail-pl1-x62e.google.com with SMTP id z1so3010584plg.6; Thu, 02 Feb 2023 12:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=KTEXTLdEtQvrB7aVFpBYAbH4Vf/ihPabgDflRw+s72o=; b=CuJhJ9UTVuPY/jraolwLg+hw6h/pKxRy1SLRd/hEO8GnE3cDoiPidADrjRGw4Tat7E jsPj+B5/JWPEzkR1ov2cP4QLjkGjelgudaCyhdc4WTw+8Tb5Oonu+M6rmd85VoAp+09n p29yqXXOCqF9Y85uU7Om7KJ2ttMYgVWNGXZB9YxNzDvxDzbpksNHc1G+p86CxKdlN0Ty +rwXXExzAQPU5AL4D29Etk7FWGP466Or/Daf4dCE9QSEqudpR8qq8SpggqjYy48/R5Nd XYVHbi+FsHBVz+Wv+DIRXgY0DRGWK3xQsCPpOzfidwB7nrd2hKVFHAH562MKRavuNJmY xtXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KTEXTLdEtQvrB7aVFpBYAbH4Vf/ihPabgDflRw+s72o=; b=cOd056a/GrX8pDWiMPmEczovXW5fRre5zYkRDlcnSekjPs8L9PBKpMH2rItQHddIJa zxZMKG68YT/e828qzS7lxnB3WJqVIf8h+jlVLkdqfvj7/BmUz722xTeyuGZCqQaLLosN oMkySNy1o0Bk7Gg2plZ1uNIZ3/BAsTOKyk33lhBzxGz72sxGq0fbc/y3cPMxemITxwmy o+rhN668Uyp8C//Jl9Yz1QKu2Jhr8ft/0qS+fdagAacdrgblmlNnly/ilzEJU3OCYlyB rjMYTeYgd5wknFO42NySWrBeShp288n48Fm7GUsRxGhcL8y/d66pmMqZ+vi4TrzFe4iS aASw== X-Gm-Message-State: AO0yUKVVM6tNk8TWqBYloZd1h3HXfzZvYt05O93EUWsAz0K1MuB8ogYS U6ZjEIEJFq2+A4yPVW5BWm4= X-Google-Smtp-Source: AK7set8Q9bsQxt4cyQu1ye65OLJScIues9R6Sdz55WQAGcTEZjBv9qXC8qRJpwpjQ6p92muQd2Vhww== X-Received: by 2002:a17:903:1111:b0:196:6ec4:52db with SMTP id n17-20020a170903111100b001966ec452dbmr8506618plh.51.1675368016015; Thu, 02 Feb 2023 12:00:16 -0800 (PST) Received: from localhost ([2620:10d:c090:400::5:48a9]) by smtp.gmail.com with ESMTPSA id 10-20020a170902c14a00b001933b4b1a49sm53850plj.183.2023.02.02.12.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 12:00:15 -0800 (PST) Date: Thu, 2 Feb 2023 10:00:14 -1000 From: Tejun Heo To: Tvrtko Ursulin Subject: Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control Message-ID: References: <20230112165609.1083270-1-tvrtko.ursulin@linux.intel.com> <20230112165609.1083270-11-tvrtko.ursulin@linux.intel.com> <27b7882e-1201-b173-6f56-9ececb5780e8@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27b7882e-1201-b173-6f56-9ececb5780e8@linux.intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Kenny.Ho@amd.com, Dave Airlie , =?iso-8859-1?Q?St=E9phane?= Marchesin , Daniel Vetter , Intel-gfx@lists.freedesktop.org, Brian Welty , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= , Tvrtko Ursulin , Zefan Li , Johannes Weiner , cgroups@vger.kernel.org, "T . J . Mercier" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello, On Thu, Feb 02, 2023 at 02:26:06PM +0000, Tvrtko Ursulin wrote: > When you say active/inactive - to what you are referring in the cgroup > world? Offline/online? For those my understanding was offline was a > temporary state while css is getting destroyed. Oh, it's just based on activity. So, for example, iocost puts a cgroup on its active list which is canned periodically when an IO is issued from an inactive cgroup. If an active cgroup doesn't have any activity between two scans, it becomes inactive and dropped from the list. drm can prolly use the same approach? > Also, I am really postponing implementing those changes until I hear at > least something from the DRM community. Yeah, that sounds like a good idea. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C86D7C05027 for ; Thu, 2 Feb 2023 20:00:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232512AbjBBUAU (ORCPT ); Thu, 2 Feb 2023 15:00:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbjBBUAR (ORCPT ); Thu, 2 Feb 2023 15:00:17 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B02BD75190; Thu, 2 Feb 2023 12:00:16 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id l4-20020a17090a850400b0023013402671so6669491pjn.5; Thu, 02 Feb 2023 12:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=KTEXTLdEtQvrB7aVFpBYAbH4Vf/ihPabgDflRw+s72o=; b=CuJhJ9UTVuPY/jraolwLg+hw6h/pKxRy1SLRd/hEO8GnE3cDoiPidADrjRGw4Tat7E jsPj+B5/JWPEzkR1ov2cP4QLjkGjelgudaCyhdc4WTw+8Tb5Oonu+M6rmd85VoAp+09n p29yqXXOCqF9Y85uU7Om7KJ2ttMYgVWNGXZB9YxNzDvxDzbpksNHc1G+p86CxKdlN0Ty +rwXXExzAQPU5AL4D29Etk7FWGP466Or/Daf4dCE9QSEqudpR8qq8SpggqjYy48/R5Nd XYVHbi+FsHBVz+Wv+DIRXgY0DRGWK3xQsCPpOzfidwB7nrd2hKVFHAH562MKRavuNJmY xtXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KTEXTLdEtQvrB7aVFpBYAbH4Vf/ihPabgDflRw+s72o=; b=vtd4FKduuXJGgzVL1qvaa0spsjrfNLAc4k4gHSW6qy0v/sEL6ZdhfriGCUDj3xOqDn hPN1nwtQlq2pR/IGXMPnSD1/1koWMvtHCOrdnuB8hFwJMlrlZ9r+6t8+rp1uC5jeXDBl 0YIyL3PsCUFZ7fA3XfsYEAaU9Flho4jsSKB1TtfbNWBW7ZZNgDj8kzXoyKak0J8kYgGw vUVgMTsgX4938hCyFW2fraSx6Evsd5yMfHLBLXebBmf8VzwlsSeSrumTKBtr2c/OZNIu kgQ0e3oUDhO41BT45j7D/kPUUuQ8j+xkCLK3jtUkX6INJvWlPs6nOCZwyFsWbggnGWQc +83g== X-Gm-Message-State: AO0yUKVxZV5IHCvHh5RWcBom9QW+Qa5/dVAkWKbOld9PTdmsF7jY321G tXf7ouxaWITGpoED3yHHSiY= X-Google-Smtp-Source: AK7set8Q9bsQxt4cyQu1ye65OLJScIues9R6Sdz55WQAGcTEZjBv9qXC8qRJpwpjQ6p92muQd2Vhww== X-Received: by 2002:a17:903:1111:b0:196:6ec4:52db with SMTP id n17-20020a170903111100b001966ec452dbmr8506618plh.51.1675368016015; Thu, 02 Feb 2023 12:00:16 -0800 (PST) Received: from localhost ([2620:10d:c090:400::5:48a9]) by smtp.gmail.com with ESMTPSA id 10-20020a170902c14a00b001933b4b1a49sm53850plj.183.2023.02.02.12.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 12:00:15 -0800 (PST) Sender: Tejun Heo Date: Thu, 2 Feb 2023 10:00:14 -1000 From: Tejun Heo To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Johannes Weiner , Zefan Li , Dave Airlie , Daniel Vetter , Rob Clark , =?iso-8859-1?Q?St=E9phane?= Marchesin , "T . J . Mercier" , Kenny.Ho@amd.com, Christian =?iso-8859-1?Q?K=F6nig?= , Brian Welty , Tvrtko Ursulin Subject: Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control Message-ID: References: <20230112165609.1083270-1-tvrtko.ursulin@linux.intel.com> <20230112165609.1083270-11-tvrtko.ursulin@linux.intel.com> <27b7882e-1201-b173-6f56-9ececb5780e8@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27b7882e-1201-b173-6f56-9ececb5780e8@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Feb 02, 2023 at 02:26:06PM +0000, Tvrtko Ursulin wrote: > When you say active/inactive - to what you are referring in the cgroup > world? Offline/online? For those my understanding was offline was a > temporary state while css is getting destroyed. Oh, it's just based on activity. So, for example, iocost puts a cgroup on its active list which is canned periodically when an IO is issued from an inactive cgroup. If an active cgroup doesn't have any activity between two scans, it becomes inactive and dropped from the list. drm can prolly use the same approach? > Also, I am really postponing implementing those changes until I hear at > least something from the DRM community. Yeah, that sounds like a good idea. Thanks. -- tejun