From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, vishal.l.verma@intel.com,
minchan@kernel.org, kbusch@kernel.org, ira.weiny@intel.com,
dave.jiang@intel.com, dan.j.williams@intel.com, axboe@kernel.dk,
hch@lst.de, Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [merged mm-stable] block-remove-rw_page.patch removed from -mm tree
Date: Fri, 3 Feb 2023 16:53:47 +0900 [thread overview]
Message-ID: <Y9y9i7UCwxUj2t40@google.com> (raw)
In-Reply-To: <Y9y9Gw0dSgwMSfIi@google.com>
On (23/02/03 16:51), Sergey Senozhatsky wrote:
> > From: Christoph Hellwig <hch@lst.de>
> > Subject: block: remove ->rw_page
> > Date: Wed, 25 Jan 2023 14:34:36 +0100
> >
> > The ->rw_page method is a special purpose bypass of the usual bio handling
> > path that is limited to single-page reads and writes and synchronous which
> > causes a lot of extra code in the drivers, callers and the block layer.
> >
> > The only remaining user is the MM swap code. Switch that swap code to
> > simply submit a single-vec on-stack bio an synchronously wait on it based
> > on a newly added QUEUE_FLAG_SYNCHRONOUS flag set by the drivers that
> > currently implement ->rw_page instead. While this touches one extra cache
> > line and executes extra code, it simplifies the block layer and drivers
> > and ensures that all feastures are properly supported by all drivers, e.g.
> > right now ->rw_page bypassed cgroup writeback entirely.
> >
> > [akpm@linux-foundation.org: fix comment typo, per Dan]
> > Link: https://lkml.kernel.org/r/20230125133436.447864-8-hch@lst.de
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> > Cc: Dave Jiang <dave.jiang@intel.com>
> > Cc: Ira Weiny <ira.weiny@intel.com>
> > Cc: Jens Axboe <axboe@kernel.dk>
> > Cc: Keith Busch <kbusch@kernel.org>
> > Cc: Minchan Kim <minchan@kernel.org>
> > Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
> > Cc: Vishal Verma <vishal.l.verma@intel.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Appologies for fat finger.
Was going to say
Tested-by: Sergey Senozhatsky <senozhatsky@chromium.org> # zram
Revieewd-by: Sergey Senozhatsky <senozhatsky@chromium.org> # zram
prev parent reply other threads:[~2023-02-03 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 6:38 [merged mm-stable] block-remove-rw_page.patch removed from -mm tree Andrew Morton
2023-02-03 7:51 ` Sergey Senozhatsky
2023-02-03 7:53 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9y9i7UCwxUj2t40@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.