From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kyle Huey <me@kylehuey.com>
Cc: kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [linux-stable-rc:linux-5.15.y 9905/9999] protection_keys.c:undefined reference to `__cpuid_count'
Date: Fri, 3 Feb 2023 09:15:36 +0100 [thread overview]
Message-ID: <Y9zCqKkP9YluVM9y@kroah.com> (raw)
In-Reply-To: <CAP045AomNRW3=gmfFgQ9c7roQVHE74+D5w1g-o72KmdnUntNDQ@mail.gmail.com>
On Tue, Jan 17, 2023 at 12:27:42PM -0800, Kyle Huey wrote:
> On Mon, Jan 16, 2023 at 3:23 PM kernel test robot <lkp@intel.com> wrote:
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > head: 5bcc318cb4cd6b13569afdfc6d7b5c8c1f408f06
> > commit: 46aa1557581ff4cc380c3b29ef516f2b15129a4e [9905/9999] selftests/vm/pkeys: Add a regression test for setting PKRU through ptrace
> > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> > reproduce:
> > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=46aa1557581ff4cc380c3b29ef516f2b15129a4e
> > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > git fetch --no-tags linux-stable-rc linux-5.15.y
> > git checkout 46aa1557581ff4cc380c3b29ef516f2b15129a4e
> > make O=/tmp/kselftest headers
> > make O=/tmp/kselftest -C tools/testing/selftests
> >
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> >
> > All error/warnings (new ones prefixed by >>):
> >
> > In file included from pkey-helpers.h:89,
> > from protection_keys.c:49:
> > pkey-x86.h: In function 'cpu_max_xsave_size':
> > >> pkey-x86.h:130:9: warning: implicit declaration of function '__cpuid_count' [-Wimplicit-function-declaration]
> > 130 | __cpuid_count(XSTATE_CPUID, 0, eax, ebx, ecx, edx);
> > | ^~~~~~~~~~~~~
> > >> pkey-x86.h:130:9: warning: 'eax' is used uninitialized [-Wuninitialized]
> > 130 | __cpuid_count(XSTATE_CPUID, 0, eax, ebx, ecx, edx);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >> pkey-x86.h:130:9: warning: 'ebx' is used uninitialized [-Wuninitialized]
> > >> pkey-x86.h:130:9: warning: 'ecx' is used uninitialized [-Wuninitialized]
> > >> pkey-x86.h:130:9: warning: 'edx' is used uninitialized [-Wuninitialized]
> > /usr/bin/ld: /tmp/cc5xWC2G.o: in function `cpu_max_xsave_size':
> > >> protection_keys.c:(.text+0xff9): undefined reference to `__cpuid_count'
> > collect2: error: ld returned 1 exit status
> > --
> > In file included from pkey-helpers.h:89,
> > from protection_keys.c:49:
> > pkey-x86.h: In function 'cpu_max_xsave_size':
> > >> pkey-x86.h:130:9: warning: implicit declaration of function '__cpuid_count' [-Wimplicit-function-declaration]
> > 130 | __cpuid_count(XSTATE_CPUID, 0, eax, ebx, ecx, edx);
> > | ^~~~~~~~~~~~~
> > >> pkey-x86.h:130:9: warning: 'eax' is used uninitialized [-Wuninitialized]
> > 130 | __cpuid_count(XSTATE_CPUID, 0, eax, ebx, ecx, edx);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >> pkey-x86.h:130:9: warning: 'ebx' is used uninitialized [-Wuninitialized]
> > >> pkey-x86.h:130:9: warning: 'ecx' is used uninitialized [-Wuninitialized]
> > >> pkey-x86.h:130:9: warning: 'edx' is used uninitialized [-Wuninitialized]
> > /usr/bin/ld: /tmp/ccvfRroq.o: in function `cpu_max_xsave_size':
> > protection_keys.c:(.text+0x124e): undefined reference to `__cpuid_count'
> > collect2: error: ld returned 1 exit status
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests
>
> That can be fixed by cherry-picking
>
> 066b34aa5461 tools: fix ARRAY_SIZE defines in tools and selftests hdrs
> e89908201e25 selftests/vm: remove ARRAY_SIZE define from individual tests
> a23039c7306f selftests: Provide local define of __cpuid_count()
>
> to 5.15. All three of these are small test harness changes.
>
> My apologies, I didn't test *building* the pkeys selftest binary on
> each kernel when I was backporting.
All now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-02-03 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 23:22 [linux-stable-rc:linux-5.15.y 9905/9999] protection_keys.c:undefined reference to `__cpuid_count' kernel test robot
2023-01-17 20:27 ` Kyle Huey
2023-02-03 8:15 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9zCqKkP9YluVM9y@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=lkp@intel.com \
--cc=me@kylehuey.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.