From: Tony Lindgren <tony@atomide.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: linux-gpio@vger.kernel.org,
Jason Kridner <jkridner@beagleboard.org>,
Robert Nelson <robertcnelson@beagleboard.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2] pinctrl: single: set function name when adding function
Date: Tue, 26 Jan 2021 09:13:07 +0200 [thread overview]
Message-ID: <YA/BA3uGXRhAVaVq@atomide.com> (raw)
In-Reply-To: <20210125203542.51513-1-drew@beagleboard.org>
* Drew Fustini <drew@beagleboard.org> [210125 20:36]:
> pcs_add_function() fails to set the function name in struct pcs_function
> when adding a new function. As a result this line in pcs_set_mux():
>
> dev_dbg(pcs->dev, "enabling %s function%i\n",
> func->name, fselector);
>
> prints "(null)" for the function:
>
> pinctrl-single 44e10800.pinmux: enabling (null) function0
> pinctrl-single 44e10800.pinmux: enabling (null) function1
> pinctrl-single 44e10800.pinmux: enabling (null) function2
> pinctrl-single 44e10800.pinmux: enabling (null) function3
>
> With this fix, the output is now:
>
> pinctrl-single 44e10800.pinmux: enabling pinmux-uart0-pins function0
> pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function1
> pinctrl-single 44e10800.pinmux: enabling pinmux-i2c0-pins function2
> pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function3
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2021-01-26 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 20:35 [PATCH v2] pinctrl: single: set function name when adding function Drew Fustini
2021-01-26 7:13 ` Tony Lindgren [this message]
2021-02-12 8:00 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA/BA3uGXRhAVaVq@atomide.com \
--to=tony@atomide.com \
--cc=drew@beagleboard.org \
--cc=jkridner@beagleboard.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robertcnelson@beagleboard.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.